vikunja
/
vikunja
6
43
Fork 72
Code Issues 150 Pull Requests 19 Packages Releases 32 Activity

Sort Order for tasks #110

Merged
konrad merged 62 commits from feature/sort-order into master 2019-12-07 14:30:52 +00:00
Conversation 1 Commits 62 Files Changed 22 +4 -2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7307eca0c3 - Show all commits

6
pkg/models/tasks.go
View File

@ -320,9 +320,11 @@ func sortTasks(tasks []*Task, by []*sortParam) {
}
for _, param := range by {
konrad commented 2019-12-03 22:04:45 +00:00
Outdated
Review
Copy Link

IMHO we could panic here, this is only an internal api. User validation input happens way earlier.

IMHO we could panic here, this is only an internal api. User validation input happens way earlier.
comparator, ok := comparators[param.sortBy]
var comparator TaskComparator
var ok bool
comparator, ok = comparators[param.sortBy]
if !ok {
// TODO: Handle case that a suitable comparator has not been found
panic("No suitable comparator for sortBy found! Param was " + param.sortBy)
konrad commented 2019-12-03 22:02:05 +00:00
Outdated
Review
Copy Link

@shilch Why are you duplicating the comparator here?

@shilch Why are you duplicating the comparator here?
shilch commented 2019-12-03 22:47:09 +00:00
Outdated
Review
Copy Link

If I didn't you would end in an infinite recursive loop because comparator would call itself.

If I didn't you would end in an infinite recursive loop because comparator would call itself.
}
// This is a descending sort, so we need to negate the comparator (i.e. switch the inputs).