vikunja/vikunja
6
43
Fork 73
Code Issues 150 Pull Requests 19 Packages Releases 32 Activity

WIP: fix(semver): fix produced version number #1472

Closed
dpschen wants to merge 1 commits from dpschen:fix-produced-semver-version-number into main
pull from: dpschen:fix-produced-semver-version-number
merge into: vikunja:main
Conversation 2 Commits 1 Files Changed 2 +2 -3
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/content/doc/setup/versions.md
View File

@ -16,7 +16,7 @@ The Vikunja api and frontend are available in two different release flavors.
## Stable ## Stable
Stable releases have a fixed version number like `0.18.2` and are published at irregular intervals whenever a new version is ready. Stable releases have a fixed version number like `0.20.2` and are published at irregular intervals whenever a new version is ready.
dpschen commented 2023-04-05 11:40:10 +00:00
Outdated
Review
Copy Link

@konrad How could we render the current version dynamically here?

@konrad How could we render the current version dynamically here?
konrad commented 2023-04-05 11:51:41 +00:00
Outdated
Review
Copy Link

Probably with a placeholder string and a ci step doing sed magic.

Probably with a placeholder string and a ci step doing sed magic.
They receive few bugfixes and security patches. They receive few bugfixes and security patches.
We use [Semantic Versioning](#) for these releases. We use [Semantic Versioning](#) for these releases.
@ -28,7 +28,7 @@ As such, they contain the current development code and are more likely to have b
There might be multiple new such builds a day. There might be multiple new such builds a day.
Versions contain the last stable version, the number of commits since then and the commit the currently running binary was built from. Versions contain the last stable version, the number of commits since then and the commit the currently running binary was built from.
They look like this: `v0.18.1+269-5cc4927b9e` They look like this: `v0.20.2-75-6049427322`
The demo instance at [try.vikunja.io](https://try.vikunja.io) automatically updates and always runs the last unstable build. The demo instance at [try.vikunja.io](https://try.vikunja.io) automatically updates and always runs the last unstable build.

1
magefile.go
View File

@ -94,7 +94,6 @@ func setVersion() {
os.Exit(1) os.Exit(1)
} }
VersionNumber = strings.Trim(string(version), "\n") VersionNumber = strings.Trim(string(version), "\n")
VersionNumber = strings.Replace(VersionNumber, "-", "+", 1)
VersionNumber = strings.Replace(VersionNumber, "-g", "-", 1) VersionNumber = strings.Replace(VersionNumber, "-g", "-", 1)
konrad commented 2023-04-05 11:14:21 +00:00
Outdated
Review
Copy Link

Can you remove this line?

Can you remove this line?
if os.Getenv("DRONE_TAG") != "" { if os.Getenv("DRONE_TAG") != "" {