vikunja/vikunja
6
43
Fork 73
Code Issues 150 Pull Requests 19 Packages Releases 32 Activity

Reverse the coupling of module log and config #1606

Merged
konrad merged 9 commits from HoffmannP/api:main into main 2023-10-03 09:28:34 +00:00
Conversation 4 Commits 9 Files Changed 13 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 61f0f65bf1 - Show all commits

3
pkg/log/logging.go
View File

@ -39,7 +39,8 @@ const logModule = `vikunja`
// loginstance is the instance of the logger which is used under the hood to log
var logInstance = logging.MustGetLogger(logModule)
// logpath is the path in which log files will be written. This value should actually never be used
// logpath is the path in which log files will be written.
konrad commented 2023-09-27 15:35:55 +00:00
Outdated
Review
Copy Link

If it's never actually used, why specify it? Please add a comment.

If it's never actually used, why specify it? Please add a comment.
👍 1
// This value is a mere fallback for other modules that could but shouldn't be used before calling ConfigLogger
var logPath = "."
// InitLogger initializes the global log handler