vikunja/vikunja
5
49
Fork 89
Code Issues 132 Pull Requests 32 Packages Releases 37 Activity

feat: improve types #2368

Merged
konrad merged 1 commits from dpschen/vikunja:fix/type-issues into main 2024-06-12 10:04:29 +00:00
Conversation 2 Commits 1 Files Changed 8 +30 -31
dpschen commented 2024-06-11 13:52:26 +00:00
Member
Copy Link

This improves several types and removes some typescript errors.

This improves several types and removes some typescript errors.
dpschen force-pushed fix/type-issues from ec17bd8004 to decad1345d 2024-06-11 19:47:17 +00:00 Compare
frederick commented 2024-06-11 19:59:39 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2368-fix-type-issues--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2368-fix-type-issues--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2024-06-11 21:13:26 +00:00
frontend/src/constants/date.ts
@ -1,4 +1,4 @@
export const DATEFNS_DATE_FORMAT_KEBAB = 'yyyy-LL-dd'
export const DATEFNS_DATE_FORMAT_KEBAB = 'yyyy-LL-dd' as const
konrad commented 2024-06-11 21:12:49 +00:00
Owner
Copy Link

Out of interest: What is the as const good for when the const is already declared as const?

Out of interest: What is the `as const` good for when the const is already declared as const?
konrad merged commit bc897a4503 into main 2024-06-12 10:04:29 +00:00
konrad deleted branch fix/type-issues 2024-06-12 10:04:30 +00:00
konrad referenced this issue from a commit 2024-06-12 10:04:39 +00:00
feat: improve types (#2368)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2368
No description provided.
Delete Branch "dpschen/vikunja:fix/type-issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?