vikunja/vikunja
5
49
Fork 89
Code Issues 132 Pull Requests 33 Packages Releases 37 Activity

fix: useTitle types #2369

Merged
konrad merged 1 commits from dpschen/vikunja:fix/2024_04-fix-useTitle-types into main 2024-06-11 20:36:50 +00:00
Conversation 1 Commits 1 Files Changed 1 +10 -10
dpschen commented 2024-06-11 13:55:07 +00:00
Member
Copy Link

This removes all type errors when using useTitle with a getter for the title string.

This removes all type errors when using `useTitle` with a getter for the title string.
dpschen force-pushed fix/2024_04-fix-useTitle-types from d4163dfe76 to 7f5c6f3ca4 2024-06-11 19:34:54 +00:00 Compare
frederick commented 2024-06-11 19:50:55 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2369-fix-202404-fix-usetitle-types--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2369-fix-202404-fix-usetitle-types--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad merged commit 9fd17aca18 into main 2024-06-11 20:36:50 +00:00
konrad referenced this issue from a commit 2024-06-11 20:36:51 +00:00
fix: useTitle types (#2369)
konrad deleted branch fix/2024_04-fix-useTitle-types 2024-06-11 20:36:51 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2369
No description provided.
Delete Branch "dpschen/vikunja:fix/2024_04-fix-useTitle-types"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?