vikunja/vikunja
8
54
Fork 94
Code Issues 130 Pull Requests 36 Packages Releases 37 Activity

feat: reduce eslint warnings #2396

Merged
konrad merged 1 commits from dpschen/vikunja:fix/reduce-eslint-warnings into main 2024-06-17 09:18:04 +00:00
Conversation 7 Commits 1 Files Changed 12 +37 -29
dpschen commented 2024-06-12 19:05:21 +00:00
Member
Copy Link

@konrad: I am not able to fix the other warnings.

@konrad: I am not able to fix the other warnings.
frederick commented 2024-06-12 19:14:29 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2396-fix-reduce-eslint-warnings--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2396-fix-reduce-eslint-warnings--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed fix/reduce-eslint-warnings from 52a01bb8ea to d21caf59a0 2024-06-12 19:28:02 +00:00 Compare
konrad commented 2024-06-12 19:49:04 +00:00
Owner
Copy Link

Looks like the lint now fails :/

Looks like the lint now fails :/
dpschen force-pushed fix/reduce-eslint-warnings from d21caf59a0 to 0489796997 2024-06-12 20:00:56 +00:00 Compare
dpschen force-pushed fix/reduce-eslint-warnings from 0489796997 to 6fcc8718a5 2024-06-13 16:20:59 +00:00 Compare
dpschen commented 2024-06-13 17:35:44 +00:00
Author
Member
Copy Link

Looks like the lint now fails :/

Should work now

> Looks like the lint now fails :/ Should work now
konrad commented 2024-06-14 09:26:57 +00:00
Owner
Copy Link

Now we have 64 warnings, on main we have 34… is that intended?

Now we have 64 warnings, on main we have 34… is that intended?
dpschen commented 2024-06-14 10:11:15 +00:00
Author
Member
Copy Link

Sry, should have mentioned that:

Yes that's intentional. I added Destructuring the 'props' will cause the value to lose reactivity as a warning to prepare for the removal of the propsDestructure option in vite.

Sry, should have mentioned that: Yes that's intentional. I added `Destructuring the 'props' will cause the value to lose reactivity` as a warning to prepare for the removal of the `propsDestructure` option in vite.
konrad commented 2024-06-17 09:15:52 +00:00
Owner
Copy Link

Gotcha, seems like I overlooked that.

Gotcha, seems like I overlooked that.
👍 1
konrad approved these changes 2024-06-17 09:17:12 +00:00
konrad merged commit 2004d129c3 into main 2024-06-17 09:18:04 +00:00
konrad deleted branch fix/reduce-eslint-warnings 2024-06-17 09:18:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2396
No description provided.
Delete Branch "dpschen/vikunja:fix/reduce-eslint-warnings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?