vikunja/vikunja
8
54
Fork 94
Code Issues 101 Pull Requests 31 Packages Releases 37 Activity

feat: use withDefaults for AddTask #2477

Merged
konrad merged 1 commits from dpschen/vikunja:feat/use-withDefaults-for-AddTask into main 2024-06-30 14:16:04 +00:00
Conversation 2 Commits 1 Files Changed 1 +4 -5
dpschen commented 2024-06-26 10:16:01 +00:00
Member
Copy Link
No description provided.
dpschen reviewed 2024-06-26 10:16:44 +00:00
frontend/src/components/tasks/AddTask.vue Outdated
@ -75,0 +70,4 @@
const props = withDefaults(defineProps<{
defaultPosition: number,
}>(), {
defaultPosition: undefined
dpschen commented 2024-06-26 10:16:44 +00:00
Author
Member
Copy Link

@konrad: I was unsure about the default value here. Is this correct?

@konrad: I was unsure about the default value here. Is this correct?
konrad commented 2024-06-28 21:19:00 +00:00
Owner
Copy Link

Seems correct. But shouldn't the type reflect that as well?

Seems correct. But shouldn't the type reflect that as well?
👍 1
dpschen commented 2024-06-29 10:20:45 +00:00
Author
Member
Copy Link

Fixed

Fixed
dpschen marked this conversation as resolved
dpschen force-pushed feat/use-withDefaults-for-AddTask from 094ca78232 to 1aa08feac0 2024-06-29 10:20:43 +00:00 Compare
frederick commented 2024-06-29 10:37:01 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2477-feat-use-withdefaults-for-addtas--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2477-feat-use-withdefaults-for-addtas--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad merged commit 7db9e64053 into main 2024-06-30 14:16:04 +00:00
konrad deleted branch feat/use-withDefaults-for-AddTask 2024-06-30 14:16:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
moved-to-github
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2477
No description provided.
Delete Branch "dpschen/vikunja:feat/use-withDefaults-for-AddTask"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?