vikunja/vikunja
5
48
Fork 86
Code Issues 150 Pull Requests 37 Packages Releases 37 Activity

feat: contain overscroll #2503

Open
dpschen wants to merge 1 commits from dpschen/vikunja:feat/contain-overscroll into main
pull from: dpschen/vikunja:feat/contain-overscroll
merge into: vikunja:main
Conversation 4 Commits 1 Files Changed 2 +2
dpschen commented 2024-07-01 16:11:17 +00:00
Member
Copy Link

Disables scrolling content behind

  • open mobile menu
  • modals
Disables scrolling content behind - open mobile menu - modals
dpschen added 1 commit 2024-07-01 16:11:20 +00:00
feat: contain overscroll
All checks were successful
continuous-integration/drone/pr Build is passing
Details
8769ab93fc
frederick commented 2024-07-01 16:21:13 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2503-feat-contain-overscroll--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2503-feat-contain-overscroll--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2024-07-01 16:55:21 +00:00
Owner
Copy Link

I'm still able to scroll with both cases you mentioned (tested with the global search bar and mobile menu). Both in Firefox.

I'm still able to scroll with both cases you mentioned (tested with the global search bar and mobile menu). Both in Firefox.
dpschen commented 2024-07-01 17:12:26 +00:00
Author
Member
Copy Link

This PR only fixes the issue partially. But it's an improvement.

For the global search it doesn't work, because the fix only applies to overflowing content of the modal. overscroll-behaviour: contain will work if we apply the overflow to the modal wrapper.

Can reproduce it for the sidebar, but only if the mouse is over the background. If the mouse is over the sidebar scrolling of the background is not possible. This is the intended by overscroll-behaviour: contain

This PR only fixes the issue partially. But it's an improvement. For the global search it doesn't work, because the fix only applies to overflowing content of the modal. `overscroll-behaviour: contain` will work if we apply the overflow to the modal wrapper. Can reproduce it for the sidebar, but only if the mouse is over the background. If the mouse is over the sidebar scrolling of the background is not possible. This is the intended by `overscroll-behaviour: contain`
dpschen commented 2024-07-01 17:13:15 +00:00
Author
Member
Copy Link

Also see the video for a better explanation of the property https://developer.chrome.com/blog/overscroll-behavior#scroll_boundaries_and_scroll_chaining

Also see the video for a better explanation of the property https://developer.chrome.com/blog/overscroll-behavior#scroll_boundaries_and_scroll_chaining
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 1 approvals granted from users or teams on the allowlist.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feat/contain-overscroll:dpschen-feat/contain-overscroll
git checkout dpschen-feat/contain-overscroll
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2503
No description provided.
Delete Branch "dpschen/vikunja:feat/contain-overscroll"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?