vikunja/vikunja
5
49
Fork 89
Code Issues 132 Pull Requests 31 Packages Releases 37 Activity

feat/tailwind-trial #2513

Merged
konrad merged 1 commits from dpschen/vikunja:feat/tailwind-trial into main 2024-07-19 07:33:14 +00:00
Conversation 6 Commits 1 Files Changed 6 +235 -2
dpschen commented 2024-07-03 17:51:06 +00:00
Member
Copy Link

🤔 I tested something… still unsure if this makes sense.

🤔 I tested something… still unsure if this makes sense.
dpschen reviewed 2024-07-03 17:52:21 +00:00
frontend/src/components/base/BaseCheckbox.vue Outdated
@ -5,3 +5,3 @@
>
<input
:id="checkboxId"
:id="id || internalId"
dpschen commented 2024-07-03 17:52:21 +00:00
Author
Member
Copy Link

ups #fixme

ups #fixme
dpschen marked this conversation as resolved
dpschen commented 2024-07-03 17:59:16 +00:00
Author
Member
Copy Link

Still not a fan of tailwind. But really not a fan of bulma…
At least tailwind is close to CSS. With bulma there are these huge unnecessary boilerplate div soups with controlling classes.

WTF is that:

image
Still not a fan of tailwind. But __really__ not a fan of bulma… At least tailwind is close to CSS. With bulma there are these huge unnecessary boilerplate div soups with controlling classes. WTF [is that](https://bulma.io/documentation/form/general/#horizontal-form): <img width="501" alt="image" src="/attachments/cc2a1c53-6aac-4644-abce-62097f7519ad">
image.png
122 KiB
dpschen force-pushed feat/tailwind-trial from 5fc5fdd8ff to ff7befc634 2024-07-03 18:02:03 +00:00 Compare
frederick commented 2024-07-03 18:14:27 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2513-feat-tailwind-trial--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2513-feat-tailwind-trial--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feat/tailwind-trial from ff7befc634 to 8c977030d3 2024-07-04 08:56:30 +00:00 Compare
konrad reviewed 2024-07-04 11:44:59 +00:00
frontend/src/views/user/settings/General.vue Outdated
@ -5,3 +5,3 @@
:loading="loading"
>
<div class="field">
<div class="tw-grid tw-grid-cols-[1fr_2fr] tw-gap-3 tw-mb-3">
konrad commented 2024-07-04 11:44:12 +00:00
Owner
Copy Link

Wouldn't this be a great opportunity to extract the input field into a separate component?

Wouldn't this be a great opportunity to extract the input field into a separate component?
dpschen commented 2024-07-06 19:30:48 +00:00
Author
Member
Copy Link

I'd like to separate that from the tailwind integration.
My original goal was to change the grid a bit. But with bulma it was so hard / wrong, because of the necessary dom structure…

I'd like to separate that from the tailwind integration. My original goal was to change the grid a bit. But with bulma it was so hard / wrong, because of the necessary dom structure…
frontend/tailwind.config.js Outdated
@ -0,0 +1,13 @@
/** @type {import('tailwindcss').Config} */
module.exports = {
konrad commented 2024-07-04 11:44:55 +00:00
Owner
Copy Link

We should also disable the preflight because it will interfer with Bulma's reset.

Or better yet, disable Bulma's reset, but that's probably a bigger change.

We should also disable the preflight because it will interfer with Bulma's reset. Or better yet, disable Bulma's reset, but that's probably a bigger change.
👍 1
dpschen commented 2024-07-06 19:38:18 +00:00
Author
Member
Copy Link

Good point.
I didn't see much difference, but who knows…

Done.

Good point. I didn't see much difference, but who knows… Done.
dpschen marked this conversation as resolved
dpschen force-pushed feat/tailwind-trial from 8c977030d3 to a3eb97ff2b 2024-07-05 08:21:38 +00:00 Compare
dpschen force-pushed feat/tailwind-trial from a3eb97ff2b to 0a38f8c221 2024-07-06 19:37:56 +00:00 Compare
dpschen force-pushed feat/tailwind-trial from 0a38f8c221 to 83c56eead8 2024-07-06 19:40:03 +00:00 Compare
dpschen force-pushed feat/tailwind-trial from 83c56eead8 to ada3ad1c2e 2024-07-08 09:13:16 +00:00 Compare
dpschen force-pushed feat/tailwind-trial from ada3ad1c2e to 3df6fca941 2024-07-15 16:26:59 +00:00 Compare
dpschen force-pushed feat/tailwind-trial from 3df6fca941 to 73046893f0 2024-07-17 21:22:34 +00:00 Compare
dpschen changed title from WIP: feat/tailwind-trial to feat/tailwind-trial 2024-07-17 21:23:20 +00:00
dpschen commented 2024-07-17 21:25:56 +00:00
Author
Member
Copy Link

@konrad This now only includes adding tailwind support.
The origin of the CI issue was rooted in the missing separation between checkbox and label (currently not possible as individual components). This has nothing to do with tailwind. Will add a new branch (based on this here) for those changes.

@konrad This now only includes adding tailwind support. The origin of the CI issue was rooted in the missing separation between checkbox and label (currently not possible as individual components). This has nothing to do with tailwind. Will add a new branch (based on this here) for those changes.
dpschen requested review from konrad 2024-07-17 21:26:07 +00:00
dpschen added a new dependency 2024-07-17 21:27:00 +00:00
#2622 WIP: feat/tailwind-general-settings
konrad merged commit bbfd5270db into main 2024-07-19 07:33:14 +00:00
konrad deleted branch feat/tailwind-trial 2024-07-19 07:33:15 +00:00
dpschen commented 2024-07-19 08:46:26 +00:00
Author
Member
Copy Link

🥳

🥳
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Blocks
#2622 WIP: feat/tailwind-general-settings
vikunja/vikunja
Reference: vikunja/vikunja#2513
No description provided.
Delete Branch "dpschen/vikunja:feat/tailwind-trial"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?