vikunja/vikunja
5
48
Fork 86
Code Issues 150 Pull Requests 36 Packages Releases 37 Activity

fix: reorder mail options #2533

Merged
konrad merged 1 commits from belidzs/vikunja:smtp-port-fix into main 2024-07-07 15:00:22 +00:00
Conversation 2 Commits 1 Files Changed 1 +1 -1
belidzs commented 2024-07-06 14:30:28 +00:00
Contributor
Copy Link

Setting the SMTP port currently doesn't have any effect since it is overridden when NewClient() executes the WithTLSPortPolicy() option

fixes #2534

Setting the SMTP port currently doesn't have any effect since it is overridden when `NewClient()` executes the `WithTLSPortPolicy()` option fixes #2534
belidzs added 1 commit 2024-07-06 14:30:31 +00:00
fix: reorder mail options
All checks were successful
continuous-integration/drone/pr Build is passing
Details
1e7871b5c0 
* Client.WithTLSPortPolicy() overrides the any previously set SMTP port setting
belidzs changed title from fix: reorder mail options to fix: reorder mail options fixes #2534 2024-07-06 14:36:35 +00:00
belidzs changed title from fix: reorder mail options fixes #2534 to fix: reorder mail options 2024-07-06 14:37:35 +00:00
frederick commented 2024-07-06 18:27:13 +00:00
Member
Copy Link

Hi belidzs!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2533-smtp-port-fix--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi belidzs! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2533-smtp-port-fix--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad merged commit 136ef58820 into main 2024-07-07 15:00:22 +00:00
konrad deleted branch smtp-port-fix 2024-07-07 15:00:23 +00:00
konrad commented 2024-07-07 15:00:41 +00:00
Owner
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2533
No description provided.
Delete Branch "belidzs/vikunja:smtp-port-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?