vikunja/vikunja
5
48
Fork 86
Code Issues 150 Pull Requests 36 Packages Releases 37 Activity

WIP: fix: local cypress tests #2538

Draft
dpschen wants to merge 1 commits from dpschen/vikunja:fix/local-cypress-test into main
pull from: dpschen/vikunja:fix/local-cypress-test
merge into: vikunja:main
Conversation 1 Commits 1 Files Changed 4 +9 -6
dpschen commented 2024-07-08 09:15:43 +00:00
Member
Copy Link
No description provided.
dpschen added the
kind/bug
 label 2024-07-08 09:15:43 +00:00
dpschen added 1 commit 2024-07-08 09:15:45 +00:00
fix: local cypress tests
All checks were successful
continuous-integration/drone/pr Build is passing
Details
75f79101c4
dpschen reviewed 2024-07-08 09:17:30 +00:00
frontend/cypress/README.md
@ -33,3 +32,4 @@
docker compose run cypress bash
```
to get a shell inside the cypress container.
dpschen commented 2024-07-08 09:17:30 +00:00
Author
Member
Copy Link

The commands after this don't work for me, since the cypress image directly quits. Instead I start test:e2e-dev. Meaning that I (ab)use this only for the api-part of the image.

The commands after this don't work for me, since the cypress image directly quits. Instead I start `test:e2e-dev`. Meaning that I (ab)use this only for the api-part of the image.
konrad commented 2024-07-08 14:01:44 +00:00
Owner
Copy Link

Does it exit with code 0?

Does it exit with code 0?
👍 1
dpschen commented 2024-07-08 17:27:14 +00:00
Author
Member
Copy Link

Yes

Yes
dpschen commented 2024-07-16 13:50:38 +00:00
Author
Member
Copy Link

Why? @konrad

Why? @konrad
konrad commented 2024-07-17 06:46:36 +00:00
Owner
Copy Link

If it would exit with some code other than 0, that would indicate an error. Since that's not the case, it has to be something else.

If it would exit with some code other than 0, that would indicate an error. Since that's not the case, it has to be something else.
👍 1
dpschen reviewed 2024-07-08 09:18:10 +00:00
frontend/cypress/docker-compose.yml
@ -6,2 +3,4 @@
image: vikunja/vikunja:unstable
environment:
VIKUNJA_LOG_LEVEL: DEBUG
VIKUNJA_CORS_ENABLE: 1
dpschen commented 2024-07-08 09:18:10 +00:00
Author
Member
Copy Link

TODO: Unsure if these entries are even needed. I only testet it with them.

TODO: Unsure if these entries are even needed. I only testet it with them.
dpschen reviewed 2024-07-08 09:19:48 +00:00
frontend/package.json
@ -39,3 +39,3 @@
"test:e2e-record-test": "start-server-and-test preview:test http://127.0.0.1:4173 'cypress run --e2e --browser chrome --record'",
"test:e2e-dev-dev": "start-server-and-test preview:dev http://127.0.0.1:4173 'cypress open --e2e'",
"test:e2e-dev": "start-server-and-test preview http://127.0.0.1:4173 'cypress open --e2e'",
"test:e2e-dev": "start-server-and-test 'vite dev --port 4173' :4173 'cypress open --e2e'",
dpschen commented 2024-07-08 09:19:48 +00:00
Author
Member
Copy Link

Before I can run test:e2d-dev I have to build via build:test.

Before I can run `test:e2d-dev` I have to build via `build:test`.
frederick commented 2024-07-08 09:25:47 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2538-fix-local-cypress-test--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2538-fix-local-cypress-test--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/local-cypress-test:dpschen-fix/local-cypress-test
git checkout dpschen-fix/local-cypress-test
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
kind/bug
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2538
No description provided.
Delete Branch "dpschen/vikunja:fix/local-cypress-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?