vikunja/vikunja
5
48
Fork 86
Code Issues 150 Pull Requests 37 Packages Releases 37 Activity

chore: simplify calculateItemPosition #2623

Open
dpschen wants to merge 1 commits from dpschen/vikunja:feat/simplify-calculateItemPosition into main
pull from: dpschen/vikunja:feat/simplify-calculateItemPosition
merge into: vikunja:main
Conversation 1 Commits 1 Files Changed 4 +24 -15
dpschen commented 2024-07-17 21:29:08 +00:00
Member
Copy Link
No description provided.
dpschen added 1 commit 2024-07-17 21:29:12 +00:00
chore: simplify calculateItemPosition
Some checks failed
continuous-integration/drone/pr Build is failing
Details
05e591164c
dpschen force-pushed feat/simplify-calculateItemPosition from 05e591164c to ab3a6bc2a3 2024-07-18 10:42:16 +00:00 Compare
frederick commented 2024-07-18 10:58:08 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2623-feat-simplify-calculateitemposit--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2623-feat-simplify-calculateitemposit--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
dpschen changed title from WIP: chore: simplify calculateItemPosition to chore: simplify calculateItemPosition 2024-07-18 11:24:09 +00:00
konrad reviewed 2024-07-19 07:42:35 +00:00
frontend/src/helpers/calculateItemPosition.ts
@ -1,4 +1,7 @@
export const calculateItemPosition = (positionBefore: number | null, positionAfter: number | null): number => {
export const calculateItemPosition = (
positionBefore: number | null = null,
konrad commented 2024-07-19 07:42:35 +00:00
Owner
Copy Link

Shouldn't this be undefined instead of null, since the callers are now maybe passing undefined?

Shouldn't this be `undefined` instead of `null`, since the callers are now maybe passing `undefined`?
dpschen commented 2024-07-19 08:45:24 +00:00
Author
Member
Copy Link

Because of the fallback positionBefore will never be undefined, so the type should be correct — but checking given the error below ;)

Because of the fallback `positionBefore` will never be `undefined`, so the type should be correct — but checking given the error below ;)
konrad requested changes 2024-07-19 07:43:48 +00:00
konrad left a comment
Owner
Copy Link

Looks like this causes foo is undefined errors when dragging tasks across kanban buckets.

Looks like this causes `foo is undefined` errors when dragging tasks across kanban buckets.
👍 1
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 1 approvals granted from users or teams on the allowlist.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feat/simplify-calculateItemPosition:dpschen-feat/simplify-calculateItemPosition
git checkout dpschen-feat/simplify-calculateItemPosition
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2623
No description provided.
Delete Branch "dpschen/vikunja:feat/simplify-calculateItemPosition"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?