vikunja/vikunja
5
48
Fork 86
Code Issues 150 Pull Requests 36 Packages Releases 37 Activity

feat: simplify SingleTaskInProject template #2626

Open
dpschen wants to merge 1 commits from dpschen/vikunja:feat/simplify-SingleTaskInProject-template into main
pull from: dpschen/vikunja:feat/simplify-SingleTaskInProject-template
merge into: vikunja:main
Conversation 2 Commits 1 Files Changed 1 +40 -33
dpschen commented 2024-07-18 11:00:18 +00:00
Member
Copy Link

Cached + only computed once => improved rendering

Cached + only computed once => improved rendering
dpschen added 1 commit 2024-07-18 11:00:22 +00:00
feat: simplify SingleTaskInProject template
All checks were successful
continuous-integration/drone/pr Build is passing
Details
0929e97072
dpschen force-pushed feat/simplify-SingleTaskInProject-template from 0929e97072 to 7bc3c5653c 2024-07-18 11:08:27 +00:00 Compare
frederick commented 2024-07-18 11:11:39 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2626-feat-simplify-singletaskinprojec--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2626-feat-simplify-singletaskinprojec--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2024-07-19 07:38:48 +00:00
frontend/src/components/tasks/partials/SingleTaskInProject.vue Outdated
@ -242,3 +245,3 @@
const showDefer = ref(false)
const isRepeating = computed(() => task.value.repeatAfter.amount > 0 || (task.value.repeatAfter.amount === 0 && task.value.repeatMode === TASK_REPEAT_MODES.REPEAT_MODE_MONTH))
const now = useNow({interval: 1000})
konrad commented 2024-07-19 07:38:48 +00:00
Owner
Copy Link

Can you change this to 60000? We don't need updates every second, every minute is plenty.

Can you change this to `60000`? We don't need updates every second, every minute is plenty.
dpschen commented 2024-11-02 20:23:31 +00:00
Author
Member
Copy Link

Originally I didn't see the useIntervalFn. Just one of them is enough.

Originally I didn't see the `useIntervalFn`. Just one of them is enough.
dpschen force-pushed feat/simplify-SingleTaskInProject-template from 7bc3c5653c to 55a4220d5f 2024-11-02 20:23:43 +00:00 Compare
konrad commented 2024-11-02 20:41:47 +00:00
Owner
Copy Link

Now the lint check is failing

Now the lint check is failing
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 1 approvals granted from users or teams on the allowlist.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feat/simplify-SingleTaskInProject-template:dpschen-feat/simplify-SingleTaskInProject-template
git checkout dpschen-feat/simplify-SingleTaskInProject-template
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2626
No description provided.
Delete Branch "dpschen/vikunja:feat/simplify-SingleTaskInProject-template"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?