vikunja/vikunja
5
48
Fork 86
Code Issues 150 Pull Requests 36 Packages Releases 37 Activity

feat: reactive flatpicker language #2628

Open
dpschen wants to merge 1 commits from dpschen/vikunja:feat/reactive-flatpicker-language into main
pull from: dpschen/vikunja:feat/reactive-flatpicker-language
merge into: vikunja:main
Conversation 1 Commits 1 Files Changed 8 +36 -29
dpschen commented 2024-07-18 12:36:36 +00:00
Member
Copy Link
No description provided.
dpschen added 1 commit 2024-07-18 12:36:39 +00:00
feat: reactive flatpicker language
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e08f496da6
frederick commented 2024-07-18 12:44:15 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2628-feat-reactive-flatpicker-languag--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2628-feat-reactive-flatpicker-languag--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
dpschen changed title from WIP: feat: reactive flatpicker language to feat: reactive flatpicker language 2024-07-18 16:28:40 +00:00
dpschen added the
kind/feature
 label 2024-07-18 16:29:45 +00:00
dpschen force-pushed feat/reactive-flatpicker-language from e08f496da6 to 9cd2725748 2024-09-22 12:36:05 +00:00 Compare
dpschen requested review from konrad 2024-09-23 04:58:19 +00:00
konrad reviewed 2024-09-23 12:34:27 +00:00
frontend/src/helpers/useFlatpickrLanguage.ts
@ -0,0 +1,22 @@
import {useAuthStore} from '@/stores/auth'
// TODO: only import needed languages
konrad commented 2024-09-23 12:34:27 +00:00
Owner
Copy Link

how could we do that?

how could we do that?
konrad commented 2024-09-23 12:36:10 +00:00
Owner
Copy Link

On the other hand, their translations file is pretty small, maybe we could just integrate that into the translations we already have in Vikunja?

https://github.com/flatpickr/flatpickr/blob/master/src/l10n/default.ts

On the other hand, their translations file is pretty small, maybe we could just integrate that into the translations we already have in Vikunja? https://github.com/flatpickr/flatpickr/blob/master/src/l10n/default.ts
dpschen commented 2024-11-02 20:36:24 +00:00
Author
Member
Copy Link

Still waiting for Firefox to catch up, then we don't need this kind of stuff anymore: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/getWeekInfo (and the other instance Intl.Locale instance methods).

Still waiting for Firefox to catch up, then we don't need this kind of stuff anymore: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/getWeekInfo (and the other instance Intl.Locale instance methods).
konrad commented 2024-11-04 06:45:38 +00:00
Owner
Copy Link

So we could merge this now and rework it when Firefox supports the relevant Intl methods?

So we could merge this now and rework it when Firefox supports the relevant Intl methods?
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 1 approvals granted from users or teams on the allowlist.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feat/reactive-flatpicker-language:dpschen-feat/reactive-flatpicker-language
git checkout dpschen-feat/reactive-flatpicker-language
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
kind/feature
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2628
No description provided.
Delete Branch "dpschen/vikunja:feat/reactive-flatpicker-language"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?