User Mentions in editor and tasks #2641
Open
ElectricCookie
wants to merge 2 commits from
ElectricCookie/vikunja:main
into main
pull from: ElectricCookie/vikunja:main
merge into: vikunja:main
vikunja:main
vikunja:renovate/dev-dependencies
vikunja:renovate/node-22.x
vikunja:renovate/tailwindcss-3.x
vikunja:renovate/go-1.x
vikunja:renovate/github.com-getsentry-sentry-go-0.x
vikunja:renovate/sentry-javascript-monorepo
vikunja:feat/improve-ProjectSettingsDelete
vikunja:feature/inline-dynamic-routes
vikunja:fix/resetEmptyTitleError
vikunja:feat/add-vite-plugin-vue-devtools
vikunja:fix/remove-postcss-easings-types
vikunja:renovate/dompurify-3.x
vikunja:renovate/pnpm-9.x
vikunja:renovate/lowlight-3.x
vikunja:renovate/sortablejs-1.x
vikunja:renovate/pinia-2.x
vikunja:renovate/vue-i18n-10.x
vikunja:renovate/major-vueuse
vikunja:renovate/major-dev-dependencies
vikunja:renovate/tiptap
vikunja:renovate/axios-1.x
vikunja:renovate/vue-router-4.x
vikunja:renovate/golangci-golangci-lint-1.x
vikunja:renovate/github.com-stretchr-testify-1.x
vikunja:renovate/github.com-go-testfixtures-testfixtures-v3-3.x
vikunja:release/0.24
vikunja:renovate/vueuse
vikunja:renovate/font-awesome
vikunja:renovate/github.com-gabriel-vasile-mimetype-1.x
vikunja:fix/saved-filter-search
vikunja:renovate/intlify-unplugin-vue-i18n-6.x
vikunja:renovate/goreleaser-nfpm-2.x
vikunja:renovate/vue-monorepo
vikunja:feat/remove-postcss-easings
vikunja:feat/move-useProjectBackground-to-composables
vikunja:renovate/intlify-unplugin-vue-i18n-5.x
vikunja:fix/reactive-ancestor-projects
vikunja:renovate/golang.org-x-term-0.x
vikunja:renovate/golang.org-x-oauth2-0.x
vikunja:renovate/golang.org-x-crypto-0.x
vikunja:renovate/golang.org-x-image-0.x
vikunja:renovate/golang.org-x-text-0.x
vikunja:renovate/golang.org-x-sys-0.x
vikunja:renovate/golang.org-x-sync-0.x
vikunja:renovate/postgres-17.x
vikunja:renovate/github.com-wneessen-go-mail-0.x
vikunja:feature/use-modern-compiler-for-sass-files-as-well
vikunja:feat/webp-and-avif-attachment-previews
vikunja:fix/tsconfig22
vikunja:feature/only-build-sourcemaps-for-sentry
vikunja:fix/tiptap-editor-reactive-destructuring
vikunja:feature/migrate-back-to-bulma
vikunja:fix/sass-add-missing-list-import
vikunja:feature/use-sass-embedded
vikunja:renovate/github.com-threedotslabs-watermill-1.x
vikunja:feature/sticky-demo-bar
vikunja:fix/remove-defineProps
vikunja:renovate/workbox-monorepo
vikunja:renovate/github.com-swaggo-swag-1.x
vikunja:renovate/node-20.x
vikunja:renovate/kyvg-vue3-notification-3.x
vikunja:fix/gantt-view-switch
vikunja:renovate/github.com-redis-go-redis-v9-9.x
vikunja:renovate/github.com-yuin-goldmark-1.x
vikunja:renovate/github.com-prometheus-client_golang-1.x
vikunja:renovate/express-4.x
vikunja:renovate/github.com-mattn-go-sqlite3-1.x
vikunja:renovate/vuemoji-picker-0.x
vikunja:feature/typesense-position-join
vikunja:feature/focus-visible
vikunja:renovate/date-fns-4.x
vikunja:renovate/flexsearch-0.x
vikunja:renovate/dario.cat-mergo-1.x
vikunja:renovate/github.com-typesense-typesense-go-2.x
vikunja:renovate/vue-i18n-9.x
vikunja:renovate/dayjs-1.x
vikunja:dependencies/golangci-lint
vikunja:renovate/github.com-coreos-go-oidc-v3-3.x
vikunja:renovate/github.com-microcosm-cc-bluemonday-1.x
vikunja:renovate/github.com-arran4-golang-ical-0.x
vikunja:renovate/ufo-1.x
vikunja:renovate/github-hotkey-3.x
vikunja:feature/better-filter-syntax
vikunja:fix/tiptap-task-list
vikunja:feature/zod-schema
vikunja:renovate/github.com-golang-jwt-jwt-v4-5.x
vikunja:feature/hide-forbidden-related-tasks
vikunja:renovate/golang-1.x
vikunja:release/0.20
vikunja:release/0.17
vikunja:release/0.16
vikunja:release/0.15
vikunja:release/0.14
vikunja:release/0.13
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
No description provided.
Delete Branch "ElectricCookie/vikunja:main"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Resolves #2614
Hi this is a simple implementation of the mentions dropdown feature in the editor.
Once a user is mentioned they get highlighted in the task as well.
I was unable to get the tsconfig to work locally with the types in the code. Any pointers are appreciated :)
Hi ElectricCookie!
Thank you for creating a PR!
I've deployed the frontend changes of this PR on a preview environment under this URL: https://2641-main--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.
This preview does not contain any changes made to the api, only the frontend.
Have a nice day!
First of all, I'm really sorry for the long delay in reviewing this PR - looks like something is broken with the email notifications in Gitea.
This looks pretty good already! I have a few suggestions, most of which are code-style related.
@ -0,0 +20,4 @@
v-else
class="item"
>
No result
This should be translated.
@ -0,0 +28,4 @@
<script lang="ts">
/* eslint-disable vue/component-api-style */
export default {
Please use the vue composition API so that it is consistent with the rest of the codebase.
@ -0,0 +33,4 @@
component = new VueRenderer(MentionList, {
// using vue 2:
// parent: this,
// propsData: props,
Please remove this commented code
And please rebase on main.
Resolves #2614 - Mentions in editor and tasksto User Mentions in editor and tasks@ElectricCookie Did you get the notification?
Checkout
From your project repository, check out a new branch and test the changes.