vikunja/vikunja
5
48
Fork 85
Code Issues 150 Pull Requests 40 Packages Releases 37 Activity

User Mentions in editor and tasks #2641

Open
ElectricCookie wants to merge 2 commits from ElectricCookie/vikunja:main into main
pull from: ElectricCookie/vikunja:main
merge into: vikunja:main
Conversation 3 Commits 2 Files Changed 5 +261
ElectricCookie commented 2024-08-16 21:18:37 +00:00
First-time contributor
Copy Link

Resolves #2614

Hi this is a simple implementation of the mentions dropdown feature in the editor.

image

Once a user is mentioned they get highlighted in the task as well.

image

I was unable to get the tsconfig to work locally with the types in the code. Any pointers are appreciated :)

Resolves #2614 Hi this is a simple implementation of the mentions dropdown feature in the editor. <img width="574" alt="image" src="attachments/563665e7-3fdd-4f86-ac81-f39f82508e0b"> Once a user is mentioned they get highlighted in the task as well. <img width="574" alt="image" src="attachments/059b4c5c-351b-4257-b323-664ac6af974c"> I was unable to get the tsconfig to work locally with the types in the code. Any pointers are appreciated :)
image.png
67 KiB
image.png
96 KiB
👍 1 🎉 3
ElectricCookie added 2 commits 2024-08-16 21:18:37 +00:00
chore: add proper import
Some checks reported errors
continuous-integration/drone/pr Build encountered an error
Details
b23407cb3f
frederick commented 2024-08-16 21:25:12 +00:00
Member
Copy Link

Hi ElectricCookie!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2641-main--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi ElectricCookie! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2641-main--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad requested changes 2024-09-07 11:12:05 +00:00
konrad left a comment
Owner
Copy Link

First of all, I'm really sorry for the long delay in reviewing this PR - looks like something is broken with the email notifications in Gitea.

This looks pretty good already! I have a few suggestions, most of which are code-style related.

First of all, I'm really sorry for the long delay in reviewing this PR - looks like something is broken with the email notifications in Gitea. This looks pretty good already! I have a few suggestions, most of which are code-style related.
frontend/src/components/input/editor/MentionList.vue
@ -0,0 +20,4 @@
v-else
class="item"
>
No result
konrad commented 2024-09-07 11:07:14 +00:00
Owner
Copy Link

This should be translated.

This should be translated.
frontend/src/components/input/editor/MentionList.vue
@ -0,0 +28,4 @@
<script lang="ts">
/* eslint-disable vue/component-api-style */
export default {
konrad commented 2024-09-07 11:08:21 +00:00
Owner
Copy Link

Please use the vue composition API so that it is consistent with the rest of the codebase.

Please use the vue composition API so that it is consistent with the rest of the codebase.
frontend/src/components/input/editor/mention.ts
@ -0,0 +33,4 @@
component = new VueRenderer(MentionList, {
// using vue 2:
// parent: this,
// propsData: props,
konrad commented 2024-09-07 11:10:32 +00:00
Owner
Copy Link

Please remove this commented code

Please remove this commented code
konrad commented 2024-09-07 11:12:30 +00:00
Owner
Copy Link

And please rebase on main.

And please rebase on main.
konrad changed title from Resolves #2614 - Mentions in editor and tasks to User Mentions in editor and tasks 2024-09-07 11:15:19 +00:00
konrad commented 2024-09-21 06:15:53 +00:00
Owner
Copy Link

@ElectricCookie Did you get the notification?

@ElectricCookie Did you get the notification?
Some checks reported errors
continuous-integration/drone/pr Build encountered an error
Required
Details
This pull request has changes conflicting with the target branch.
  • frontend/package.json
  • frontend/pnpm-lock.yaml
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:ElectricCookie-main
git checkout ElectricCookie-main
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2641
No description provided.
Delete Branch "ElectricCookie/vikunja:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?