fix: partial fix to allow list tasks in ios reminders app #2717
No reviewers
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#2717
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "jd/vikunja:main"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR introduces a partial fix for the CalDAV task listing bug (#753) when handling PROPFIND requests with
Depth: 1
, improving task visibility in the iOS Reminders app.Notes:
/dav/projects/{id} url
.This is my first time working with Golang and CalDAV, so I’d really appreciate any feedback or suggestions on the code structure, style, or any improvements I could make.
Looks pretty good already!
Please fix the lint issues. Can you also add a test for this?
@ -95,0 +96,4 @@
// If the request is withChildren (Depth: 1), we need to return all tasks of the project
if withChildren {
var resources []data.Resource
resources = append(resources, r)
You could initialize this as
resource = []data.Resource{r}
@ -95,0 +108,4 @@
}
taskResourceInstance := data.NewResource(getTaskURL(&vcls.project.Tasks[i].Task), &taskResource)
taskResourceInstance.Name = vcls.project.Tasks[i].Title
resources = append(resources, taskResourceInstance)
Can you extract this out in a new function? A very similar logic is used in
GetResourcesByList
below.Hi jd!
Thank you for creating a PR!
I've deployed the frontend changes of this PR on a preview environment under this URL: https://2717-main--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.
This preview does not contain any changes made to the api, only the frontend.
Have a nice day!
Thanks!