vikunja/vikunja
5
48
Fork 86
Code Issues 150 Pull Requests 37 Packages Releases 37 Activity

wip: fix: TipTap editor reactive destructuring #2798

Draft
dpschen wants to merge 1 commits from fix/tiptap-editor-reactive-destructuring into main
pull from: fix/tiptap-editor-reactive-destructuring
merge into: vikunja:main
Conversation 5 Commits 1 Files Changed 1 +44 -66
dpschen commented 2024-11-01 17:10:06 +00:00
Member
Copy Link

Fixes:

Screenshot 2024-11-01 at 18.09.40.png
Fixes: <img width="878" alt="Screenshot 2024-11-01 at 18.09.40.png" src="attachments/b3a1e12d-95cf-4cc9-8b7e-696565201c0d">
Screenshot 2024-11-01 at 18.09.40.png
134 KiB
dpschen added the
kind/bug
 label 2024-11-01 17:10:06 +00:00
konrad was assigned by dpschen 2024-11-01 17:10:06 +00:00
dpschen added 1 commit 2024-11-01 17:10:10 +00:00
fix: TipTap editor reactive destructuring
Some checks failed
continuous-integration/drone/pr Build is failing
Details
8a5c45b52e
konrad commented 2024-11-01 19:15:08 +00:00
Owner
Copy Link

Can you fix the lint issue?

Can you fix the lint issue?
dpschen force-pushed fix/tiptap-editor-reactive-destructuring from 8a5c45b52e to d95115766b 2024-11-02 17:23:17 +00:00 Compare
konrad approved these changes 2024-11-02 17:26:47 +00:00
konrad scheduled this pull request to auto merge when all checks succeed 2024-11-02 17:27:07 +00:00
frederick commented 2024-11-02 17:31:31 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2798-fix-tiptap-editor-reactive-destr--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2798-fix-tiptap-editor-reactive-destr--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2024-11-02 18:06:47 +00:00
Owner
Copy Link

Tests are now failing

Tests are now failing
👍 1
konrad canceled auto merging this pull request when all checks succeed 2024-11-02 18:06:50 +00:00
dpschen force-pushed fix/tiptap-editor-reactive-destructuring from d95115766b to 17550bf158 2024-11-02 19:03:07 +00:00 Compare
konrad commented 2024-11-02 20:42:04 +00:00
Owner
Copy Link

Tests are still failing

Tests are still failing
👍 1
konrad reviewed 2024-11-02 20:42:25 +00:00
frontend/src/components/input/editor/TipTap.vue
@ -325,3 +317,3 @@
watch(
() => modelValue,
modelValue,
konrad commented 2024-11-02 20:42:21 +00:00
Owner
Copy Link

What is the difference here?

What is the difference here?
dpschen commented 2024-11-03 14:13:02 +00:00
Author
Member
Copy Link

Without prop destructuring and with the new defineModel it needs to be:

() => modelValue.value

...which is in this context– as you probably assumed – equivalent to:

modelValue

Main reason for me is that I think the single value is simpler to read.
Additionally it could be (unsure) that Vue is able to optimise reactivity tracking 🤷‍♂️

Without prop destructuring and with the new `defineModel` it needs to be: ```js () => modelValue.value ``` ...which is in this context– as you probably assumed – equivalent to: ```js modelValue ``` Main reason for me is that I think the single value is simpler to read. Additionally it could be (unsure) that Vue is able to optimise reactivity tracking 🤷‍♂️
dpschen marked this conversation as resolved
dpschen commented 2024-11-03 14:13:18 +00:00
Author
Member
Copy Link

Tests are still failing

Am still on this. Will mark as wip again.

> Tests are still failing Am still on this. Will mark as wip again.
dpschen changed title from fix: TipTap editor reactive destructuring to wip: fix: TipTap editor reactive destructuring 2024-11-03 14:13:27 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/tiptap-editor-reactive-destructuring:fix/tiptap-editor-reactive-destructuring
git checkout fix/tiptap-editor-reactive-destructuring
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
kind/bug
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees konrad
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2798
No description provided.
Delete Branch "fix/tiptap-editor-reactive-destructuring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?