wip: fix: TipTap editor reactive destructuring #2798

Draft
dpschen wants to merge 1 commits from fix/tiptap-editor-reactive-destructuring into main
Member

Fixes:

Screenshot 2024-11-01 at 18.09.40.png
Fixes: <img width="878" alt="Screenshot 2024-11-01 at 18.09.40.png" src="attachments/b3a1e12d-95cf-4cc9-8b7e-696565201c0d">
dpschen added the
kind/bug
label 2024-11-01 17:10:06 +00:00
konrad was assigned by dpschen 2024-11-01 17:10:06 +00:00
dpschen added 1 commit 2024-11-01 17:10:10 +00:00
fix: TipTap editor reactive destructuring
Some checks failed
continuous-integration/drone/pr Build is failing
8a5c45b52e
Owner

Can you fix the lint issue?

Can you fix the lint issue?
dpschen force-pushed fix/tiptap-editor-reactive-destructuring from 8a5c45b52e to d95115766b 2024-11-02 17:23:17 +00:00 Compare
konrad approved these changes 2024-11-02 17:26:47 +00:00
konrad scheduled this pull request to auto merge when all checks succeed 2024-11-02 17:27:07 +00:00
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2798-fix-tiptap-editor-reactive-destr--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2798-fix-tiptap-editor-reactive-destr--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
Owner

Tests are now failing

Tests are now failing
konrad canceled auto merging this pull request when all checks succeed 2024-11-02 18:06:50 +00:00
dpschen force-pushed fix/tiptap-editor-reactive-destructuring from d95115766b to 17550bf158 2024-11-02 19:03:07 +00:00 Compare
Owner

Tests are still failing

Tests are still failing
konrad reviewed 2024-11-02 20:42:25 +00:00
@ -325,3 +317,3 @@
watch(
() => modelValue,
modelValue,
Owner

What is the difference here?

What is the difference here?
Author
Member

Without prop destructuring and with the new defineModel it needs to be:

() => modelValue.value

...which is in this context– as you probably assumed – equivalent to:

modelValue

Main reason for me is that I think the single value is simpler to read.
Additionally it could be (unsure) that Vue is able to optimise reactivity tracking 🤷‍♂️

Without prop destructuring and with the new `defineModel` it needs to be: ```js () => modelValue.value ``` ...which is in this context– as you probably assumed – equivalent to: ```js modelValue ``` Main reason for me is that I think the single value is simpler to read. Additionally it could be (unsure) that Vue is able to optimise reactivity tracking 🤷‍♂️
dpschen marked this conversation as resolved
Author
Member

Tests are still failing

Am still on this. Will mark as wip again.

> Tests are still failing Am still on this. Will mark as wip again.
dpschen changed title from fix: TipTap editor reactive destructuring to wip: fix: TipTap editor reactive destructuring 2024-11-03 14:13:27 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/tiptap-editor-reactive-destructuring:fix/tiptap-editor-reactive-destructuring
git checkout fix/tiptap-editor-reactive-destructuring
Sign in to join this conversation.
No Reviewers
No Milestone
No Assignees konrad
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2798
No description provided.