vikunja/vikunja
Archived
8
54
Fork 94
Code Issues 101 Pull Requests 31 Packages Releases 37 Activity

feat: inline dynamic component definitions in routes #2812

Merged
konrad merged 1 commits from feature/inline-dynamic-routes into main 2025-03-29 15:06:07 +00:00
Conversation 6 Commits 1 Files Changed 1 +51 -102
dpschen commented 2024-11-05 11:08:56 +00:00
Member
Copy Link
No description provided.
dpschen added 1 commit 2024-11-05 11:08:59 +00:00
feat: inline dynamic component definitions in routes
Some checks failed
continuous-integration/drone/pr Build is failing
Details
98ccfd7e79
frederick commented 2024-11-05 11:17:51 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2812-feature-inline-dynamic-routes--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2812-feature-inline-dynamic-routes--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2024-11-06 07:27:13 +00:00
Owner
Copy Link

Looks like the tests are now failing

Looks like the tests are now failing
dpschen force-pushed feature/inline-dynamic-routes from 98ccfd7e79 to 0211d70af1 2024-11-15 12:38:07 +00:00 Compare
dpschen force-pushed feature/inline-dynamic-routes from 0211d70af1 to 6605dcbcf3 2024-11-30 18:19:16 +00:00 Compare
dpschen commented 2025-01-14 13:36:07 +00:00
Author
Member
Copy Link

@konrad Do you have any ideas regarding the failing pipeline here?

I think I'm blocked on #2950 for the same reason because it's based on this PR.

The issue seems to be a timing problem. Specifically, LinkSharingAuth is now being loaded dynamically, whereas it was synchronous before. Because of this, something is failing. Since I don't fully understand the authentication mechanism (it's spread across many files), I haven't been able to debug it. I've tried several times but just can't make progress.

@konrad Do you have any ideas regarding the failing pipeline here? I think I'm blocked on https://kolaente.dev/vikunja/vikunja/pulls/2950 for the same reason because it's based on this PR. The issue seems to be a timing problem. Specifically, `LinkSharingAuth` is now being loaded dynamically, whereas it was synchronous before. Because of this, something is failing. Since I don't fully understand the authentication mechanism (it's spread across many files), I haven't been able to debug it. I've tried several times but just can't make progress.
konrad commented 2025-01-14 13:38:22 +00:00
Owner
Copy Link

Does it work if the link share auth is loaded synchronous?

Does it work if the link share auth is loaded synchronous?
dpschen force-pushed feature/inline-dynamic-routes from 6605dcbcf3 to db16ad21ff 2025-01-17 12:05:56 +00:00 Compare
dpschen force-pushed feature/inline-dynamic-routes from 9cf1ca8860 to 6203155080 2025-01-17 13:25:45 +00:00 Compare
dpschen force-pushed feature/inline-dynamic-routes from 6203155080 to 356e83a6c9 2025-01-17 14:00:16 +00:00 Compare
dpschen commented 2025-01-17 14:02:32 +00:00
Author
Member
Copy Link

Does it work if the link share auth is loaded synchronous?

Seems to work, but loading routes async is a requirement for using that route via unplugin-vue-router

> Does it work if the link share auth is loaded synchronous? Seems to work, but loading routes async is a requirement for using that route via unplugin-vue-router
konrad reviewed 2025-01-17 15:14:31 +00:00
frontend/src/router/index.ts Outdated
@ -211,3 +158,3 @@
path: '/share/:share/auth',
name: 'link-share.auth',
component: LinkShareAuthComponent,
// FIXME: use dynamic imports
konrad commented 2025-01-17 15:14:21 +00:00
Owner

Maybe add a comment why this isn't using a dynamic import?

Maybe add a comment why this isn't using a dynamic import?
dpschen commented 2025-01-19 20:03:46 +00:00
Author
Member

As written before:

Seems to work, but loading routes async is a requirement for using that route via unplugin-vue-router

So for #2950 sadly this is still not a real solution.
For me this seems to be a race condition in the auth implementation.

Any ideas?

As written before: > Seems to work, but loading routes async is a requirement for using that route via unplugin-vue-router So for https://kolaente.dev/vikunja/vikunja/pulls/2950 sadly this is still not a real solution. For me this seems to be a race condition in the auth implementation. Any ideas?
konrad commented 2025-01-19 20:06:08 +00:00
Owner

I think it's fine to include this in the bundle, but a comment saying "we're including this in the bundle because" is better than a FIXME :)

I think it's fine to include this in the bundle, but a comment saying "we're including this in the bundle because" is better than a `FIXME` :)
dpschen force-pushed feature/inline-dynamic-routes from 356e83a6c9 to 7e787c9a3b 2025-01-19 20:35:14 +00:00 Compare
konrad merged commit a8999336f7 into main 2025-03-29 15:06:07 +00:00
konrad deleted branch feature/inline-dynamic-routes 2025-03-29 15:06:09 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
moved-to-github
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
3 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2812
No description provided.
Delete Branch "feature/inline-dynamic-routes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?