vikunja/vikunja
5
48
Fork 86
Code Issues 150 Pull Requests 36 Packages Releases 37 Activity

feat: inline dynamic component definitions in routes #2812

Open
dpschen wants to merge 1 commits from feature/inline-dynamic-routes into main
pull from: feature/inline-dynamic-routes
merge into: vikunja:main
Conversation 2 Commits 1 Files Changed 1 +44 -102
dpschen commented 2024-11-05 11:08:56 +00:00
Member
Copy Link
No description provided.
dpschen added 1 commit 2024-11-05 11:08:59 +00:00
feat: inline dynamic component definitions in routes
Some checks failed
continuous-integration/drone/pr Build is failing
Details
98ccfd7e79
frederick commented 2024-11-05 11:17:51 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2812-feature-inline-dynamic-routes--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2812-feature-inline-dynamic-routes--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2024-11-06 07:27:13 +00:00
Owner
Copy Link

Looks like the tests are now failing

Looks like the tests are now failing
dpschen force-pushed feature/inline-dynamic-routes from 98ccfd7e79 to 0211d70af1 2024-11-15 12:38:07 +00:00 Compare
dpschen force-pushed feature/inline-dynamic-routes from 0211d70af1 to 6605dcbcf3 2024-11-30 18:19:16 +00:00 Compare
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 1 approvals granted from users or teams on the allowlist.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/inline-dynamic-routes:feature/inline-dynamic-routes
git checkout feature/inline-dynamic-routes
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2812
No description provided.
Delete Branch "feature/inline-dynamic-routes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?