vikunja/vikunja
8
54
Fork 94
Code Issues 101 Pull Requests 31 Packages Releases 37 Activity

fix: resetEmptyTitleError #2889

Merged
konrad merged 1 commits from fix/resetEmptyTitleError into main 2024-12-10 20:08:17 +00:00
Conversation 6 Commits 1 Files Changed 1 +5 -8
dpschen commented 2024-11-30 18:14:09 +00:00
Member
Copy Link
No description provided.
dpschen added 1 commit 2024-11-30 18:14:11 +00:00
fix: resetEmptyTitleError
All checks were successful
continuous-integration/drone/pr Build is passing
Details
0fabb49f13
dpschen requested review from konrad 2024-11-30 18:14:15 +00:00
frederick commented 2024-11-30 18:27:55 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2889-fix-resetemptytitleerror--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2889-fix-resetemptytitleerror--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2024-12-04 16:49:13 +00:00
konrad left a comment
Owner
Copy Link

What does this fix?

What does this fix?
dpschen commented 2024-12-04 19:01:11 +00:00
Author
Member
Copy Link

What does this fix?
Sry should have written that in description.

  • event.which is deprecated
  • the defined range doesn’t cover letters like „ä“
  • the range doesn’t seem to be necessary at all as long as we continue to check for an empty input

Does that make sense?

> What does this fix? Sry should have written that in description. - `event.which` [is deprecated](https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/which) - the defined range doesn’t cover letters like „ä“ - the range doesn’t seem to be necessary at all as long as we continue to check for an empty input Does that make sense?
👍 1
konrad requested changes 2024-12-05 21:09:57 +00:00
Dismissed
konrad left a comment
Owner
Copy Link

When pressing enter without entering anything in the add task input, the error messages is now visible only for a few 100ms and then hidden.

When pressing enter without entering anything in the add task input, the error messages is now visible only for a few 100ms and then hidden.
dpschen force-pushed fix/resetEmptyTitleError from 0fabb49f13 to a6f2bc7819 2024-12-06 10:35:18 +00:00 Compare
dpschen changed title from fix: resetEmptyTitleError to WIP: fix: resetEmptyTitleError 2024-12-06 14:04:39 +00:00
dpschen force-pushed fix/resetEmptyTitleError from a6f2bc7819 to d030083736 2024-12-10 15:35:08 +00:00 Compare
dpschen changed title from WIP: fix: resetEmptyTitleError to fix: resetEmptyTitleError 2024-12-10 17:06:16 +00:00
dpschen force-pushed fix/resetEmptyTitleError from d030083736 to f2ae5af504 2024-12-10 17:07:05 +00:00 Compare
dpschen commented 2024-12-10 17:41:38 +00:00
Author
Member
Copy Link

When pressing enter without entering anything in the add task input, the error messages is now visible only for a few 100ms and then hidden.

This should work now

> When pressing enter without entering anything in the add task input, the error messages is now visible only for a few 100ms and then hidden. This should work now
dpschen requested review from konrad 2024-12-10 17:41:44 +00:00
konrad approved these changes 2024-12-10 20:08:06 +00:00
konrad left a comment
Owner
Copy Link

Thanks!

Thanks!
konrad merged commit 07df606c68 into main 2024-12-10 20:08:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
moved-to-github
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2889
No description provided.
Delete Branch "fix/resetEmptyTitleError"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?