vikunja/vikunja
8
54
Fork 94
Code Issues 101 Pull Requests 31 Packages Releases 37 Activity

feat: withDefaults for RelatedTasks #3018

Merged
konrad merged 1 commits from feat/withDefaults-for-RelatedTasks into main 2025-01-17 07:56:58 +00:00
Conversation 2 Commits 1 Files Changed 1 +12 -22
dpschen commented 2025-01-16 13:27:21 +00:00
Member
Copy Link
No description provided.
konrad was assigned by dpschen 2025-01-16 13:27:21 +00:00
dpschen added 1 commit 2025-01-16 13:27:23 +00:00
feat: withDefaults for RelatedTasks
All checks were successful
continuous-integration/drone/pr Build is passing
Details
0b45d7f3d1
dpschen requested review from konrad 2025-01-16 13:27:26 +00:00
dpschen reviewed 2025-01-16 13:28:12 +00:00
frontend/src/components/tasks/partials/RelatedTasks.vue
@ -230,0 +216,4 @@
initialRelatedTasks: () => ({}),
showNoRelationsNotice: false,
projectId: 0,
editEnabled: true, // this seems like a mistake
dpschen commented 2025-01-16 13:28:12 +00:00
Author
Member
Copy Link

Does this make sense to you? Usually I think all components should default to read onlyif the option exists.

Does this make sense to you? Usually I think all components should default to read onlyif the option exists.
konrad commented 2025-01-17 07:56:51 +00:00
Owner
Copy Link

I see what you mean, my guess is I added that prop after wanting to make it read-only somewhere but not update the prop everywhere.

I see what you mean, my guess is I added that prop after wanting to make it read-only somewhere but not update the prop everywhere.
frederick commented 2025-01-16 13:33:13 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://3018-feat-withdefaults-for-relatedtas--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://3018-feat-withdefaults-for-relatedtas--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad merged commit 70e027a84e into main 2025-01-17 07:56:58 +00:00
konrad deleted branch feat/withDefaults-for-RelatedTasks 2025-01-17 07:57:00 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
moved-to-github
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees konrad
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#3018
No description provided.
Delete Branch "feat/withDefaults-for-RelatedTasks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?