vikunja/vikunja
8
54
Fork 94
Code Issues 130 Pull Requests 36 Packages Releases 37 Activity

fix: remove date-fns #3039

Merged
konrad merged 2 commits from fix/replace-date-fns into main 2025-02-21 15:43:00 +00:00
Conversation 1 Commits 2 Files Changed 13 +45 -54
konrad commented 2025-01-21 14:55:40 +00:00
Owner
Copy Link

This removes date-fns and replaces it with the already used dayjs library. It does not make sense to have two libraries for the same purpose, and dayjs seems to be smaller and its translations are already integrated. Since we have to use dayjs because it is used by the gantt chart, this was the obvious way to go (instead of replacing dayjs with date-fns).

Resolves https://github.com/go-vikunja/vikunja/issues/391

This removes date-fns and replaces it with the already used dayjs library. It does not make sense to have two libraries for the same purpose, and dayjs seems to be smaller and its translations are already integrated. Since we have to use dayjs because it is used by the gantt chart, this was the obvious way to go (instead of replacing dayjs with date-fns). Resolves https://github.com/go-vikunja/vikunja/issues/391
dpschen was assigned by konrad 2025-01-21 14:55:40 +00:00
konrad added 1 commit 2025-01-21 14:55:42 +00:00
fix: remove date-fns
Some checks failed
continuous-integration/drone/pr Build is failing
Details
bbfc35d04f 
This removes date-fns and replaces it with the already used dayjs library. It does not make sense to have two libraries for the same purpose, and dayjs seems to be smaller and its translations are already integrated. Since we have to use dayjs because it is used by the gantt chart, this was the obvious way to go (instead of replacing dayjs with date-fns).

Resolves https://github.com/go-vikunja/vikunja/issues/391
konrad requested review from dpschen 2025-01-21 14:55:44 +00:00
frederick commented 2025-01-21 14:58:04 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://3039-fix-replace-date-fns--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://3039-fix-replace-date-fns--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad force-pushed fix/replace-date-fns from bbfc35d04f to 313ecd704a 2025-02-21 12:36:37 +00:00 Compare
konrad force-pushed fix/replace-date-fns from 313ecd704a to 3707c3f27d 2025-02-21 13:00:44 +00:00 Compare
konrad added 1 commit 2025-02-21 15:26:02 +00:00
fix: test assertions
All checks were successful
continuous-integration/drone/pr Build is passing
Details
99a8e17c79
konrad scheduled this pull request to auto merge when all checks succeed 2025-02-21 15:42:32 +00:00
konrad merged commit 021d71b90e into main 2025-02-21 15:43:00 +00:00
konrad deleted branch fix/replace-date-fns 2025-02-21 15:43:01 +00:00
konrad referenced this issue from a commit 2025-02-21 15:43:02 +00:00
fix: remove date-fns (#3039)
Sign in to join this conversation.
Reviewers
No Reviewers
dpschen
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees dpschen
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#3039
No description provided.
Delete Branch "fix/replace-date-fns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?