vikunja/vikunja
8
54
Fork 94
Code Issues 130 Pull Requests 36 Packages Releases 37 Activity

webdav: Return other status codes than 500 #3065

Merged
konrad merged 2 commits from das_j/vikunja:main into main 2025-02-06 12:38:29 +00:00
Conversation 3 Commits 2 Files Changed 1 +6 -1
das_j commented 2025-02-05 08:18:24 +00:00
Contributor
Copy Link

This allows WebDav clients to behave properly. In particular, DavX5 will
error out on syncing the collections list rather than removing deleted
projects from its local cache, as reported in
https://community.vikunja.io/t/deleting-a-project-breaks-caldav/3315/3

This allows WebDav clients to behave properly. In particular, DavX5 will error out on syncing the collections list rather than removing deleted projects from its local cache, as reported in https://community.vikunja.io/t/deleting-a-project-breaks-caldav/3315/3
das_j added 1 commit 2025-02-05 08:18:26 +00:00
webdav: Return other status codes than 500
Some checks failed
continuous-integration/drone/pr Build is failing
Details
397a89fff8 
This allows WebDav clients to behave properly. In particular, DavX5 will
error out on syncing the collections list rather than removing deleted
projects from its local cache, as reported in
https://community.vikunja.io/t/deleting-a-project-breaks-caldav/3315/3
konrad reviewed 2025-02-05 08:31:20 +00:00
pkg/routes/caldav/handler.go Outdated
@ -70,3 +74,3 @@
storage.task, err = caldav2.ParseTaskFromVTODO(vtodo)
if err != nil {
return echo.ErrInternalServerError.SetInternal(err)
return models.ErrInvalidData{Message: "Invalid task"}
konrad commented 2025-02-05 08:31:20 +00:00
Owner
Copy Link

Can you log the error?

Can you log the error?
das_j marked this conversation as resolved
das_j force-pushed main from 397a89fff8 to 12fa2e4651 2025-02-05 08:33:52 +00:00 Compare
konrad added 1 commit 2025-02-06 07:56:05 +00:00
Merge branch 'main' into main
All checks were successful
continuous-integration/drone/pr Build is passing
Details
2831d06590
konrad approved these changes 2025-02-06 07:56:30 +00:00
konrad left a comment
Owner
Copy Link

Thanks! Merging when the CI passes.

Thanks! Merging when the CI passes.
konrad scheduled this pull request to auto merge when all checks succeed 2025-02-06 07:57:51 +00:00
frederick commented 2025-02-06 11:06:50 +00:00
Member
Copy Link

Hi das_j!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://3065-main--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi das_j! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://3065-main--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
👀 1
konrad merged commit 989a40ad42 into main 2025-02-06 12:38:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#3065
No description provided.
Delete Branch "das_j/vikunja:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?