vikunja/vikunja
6
43
Fork 72
Code Issues 151 Pull Requests 17 Packages Releases 32 Activity

fetch tasks for caldav lists #641

Merged
konrad merged 6 commits from freaktechnik/api:caldav-tasks into master 2020-10-18 10:40:51 +00:00
Conversation 2 Commits 6 Files Changed 2 +6 -5
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 891ae88c86 - Show all commits

9
pkg/routes/caldav/listStorageProvider.go
View File

@ -403,17 +403,18 @@ func (vcls *VikunjaCaldavListStorage) getListRessource(isCollection bool) (rr Vi
tk := models.TaskCollection{
ListID: vcls.list.ID,
}
var iface interface{}
iface, _, _, err = tk.ReadAll(vcls.user, "", 1, 1000)
iface, _, _, err := tk.ReadAll(vcls.user, "", 1, 1000)
if err != nil {
return
}
tasks, ok := iface.([]*models.Task)
if ok {
if !ok {
panic("Tasks returned from TaskCollection.ReadAll are not []*models.Task!")
konrad marked this conversation as resolved Outdated
konrad commented 2020-08-24 19:55:14 +00:00
Outdated
Review
Copy Link

By design, this should always be true, if it isn't something is wrong with the implementation. Could you add a panic in that case? (In an else) That way it would be catched in the tests if it fails.

By design, this should always be true, if it isn't something is wrong with the implementation. Could you add a `panic` in that case? (In an `else`) That way it would be catched in the tests if it fails.
konrad commented 2020-10-17 20:09:00 +00:00
Review
Copy Link

Done.

Done.
}
listTasks = tasks
vcls.list.Tasks = tasks
}
}
rr = VikunjaListResourceAdapter{
list: vcls.list,