From 5b825f1cc812a442c770b6e11d87d11e94d4b3b5 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 8 Jul 2021 10:34:03 +0200
Subject: [PATCH] Make sure a bucket exists or use the default bucket when
 importing tasks

---
 .../migration/create_from_structure.go        | 21 ++++++++++++-------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/pkg/modules/migration/create_from_structure.go b/pkg/modules/migration/create_from_structure.go
index 902a06c0a00..148c8aee371 100644
--- a/pkg/modules/migration/create_from_structure.go
+++ b/pkg/modules/migration/create_from_structure.go
@@ -114,18 +114,22 @@ func insertFromStructure(s *xorm.Session, str []*models.NamespaceWithLists, user
 
 			log.Debugf("[creating structure] Creating %d tasks", len(tasks))
 
-			// Create all tasks
-			for _, t := range tasks {
-				bucket, exists := buckets[t.BucketID]
+			setBucketOrDefault := func(task *models.Task) {
+				bucket, exists := buckets[task.BucketID]
 				if exists {
-					t.BucketID = bucket.ID
-				} else if t.BucketID > 0 {
-					log.Debugf("[creating structure] No bucket created for original bucket id %d", t.BucketID)
-					t.BucketID = 0
+					task.BucketID = bucket.ID
+				} else if task.BucketID > 0 {
+					log.Debugf("[creating structure] No bucket created for original bucket id %d", task.BucketID)
+					task.BucketID = 0
 				}
-				if !exists || t.BucketID == 0 {
+				if !exists || task.BucketID == 0 {
 					needsDefaultBucket = true
 				}
+			}
+
+			// Create all tasks
+			for _, t := range tasks {
+				setBucketOrDefault(t)
 
 				t.ListID = l.ID
 				err = t.Create(s, user)
@@ -148,6 +152,7 @@ func insertFromStructure(s *xorm.Session, str []*models.NamespaceWithLists, user
 					for _, rt := range tasks {
 						// First create the related tasks if they do not exist
 						if rt.ID == 0 {
+							setBucketOrDefault(rt)
 							rt.ListID = t.ListID
 							err = rt.Create(s, user)
 							if err != nil {