fix(lists): return correct max right for lists where the user has created the namespace

pkg/models/list_rights.go

@@ -202,7 +202,7 @@ func (l *List) isOwner(u *user.User) bool {
 func (l *List) checkRight(s *xorm.Session, a web.Auth, rights ...Right) (bool, int, error) {
 
 	/*
-			The following loop creates an sql condition like this one:
+			The following loop creates a sql condition like this one:
 
 		    (ul.user_id = 1 AND ul.right = 1) OR (un.user_id = 1 AND un.right = 1) OR
 			(tm.user_id = 1 AND tn.right = 1) OR (tm2.user_id = 1 AND tl.right = 1) OR
@@ -242,16 +242,19 @@ func (l *List) checkRight(s *xorm.Session, a web.Auth, rights ...Right) (bool, i
 	conds = append(conds, builder.Eq{"n.owner_id": a.GetID()})
 
 	type allListRights struct {
-		UserNamespace NamespaceUser `xorm:"extends"`
-		UserList      ListUser      `xorm:"extends"`
+		UserNamespace *NamespaceUser `xorm:"extends"`
+		UserList      *ListUser      `xorm:"extends"`
 
-		TeamNamespace TeamNamespace `xorm:"extends"`
-		TeamList      TeamList      `xorm:"extends"`
+		TeamNamespace *TeamNamespace `xorm:"extends"`
+		TeamList      *TeamList      `xorm:"extends"`
+
+		NamespaceOwnerID int64 `xorm:"namespaces_owner_id"`
 	}
 
 	r := &allListRights{}
 	var maxRight = 0
 	exists, err := s.
+		Select("l.*, un.right, ul.right, tn.right, tl.right, n.owner_id as namespaces_owner_id").
 		Table("lists").
 		Alias("l").
 		// User stuff
@@ -285,6 +288,9 @@ func (l *List) checkRight(s *xorm.Session, a web.Auth, rights ...Right) (bool, i
 	if int(r.TeamList.Right) > maxRight {
 		maxRight = int(r.TeamList.Right)
 	}
+	if r.NamespaceOwnerID == a.GetID() {
+		maxRight = int(RightAdmin)
+	}
 
 	return exists, maxRight, err
 }