LordGaav
0 Followers · 0 Following
  • Joined on 2021-11-06
Repositories
1
 Projects Packages Code Public Activity Starred Repositories
LordGaav commented on issue vikunja/vikunja#966 2021-12-20 11:23:39 +00:00
Vikunja only requests openid scope when authenticating with Authentik

For me yes, not sure if @birdcolour 's original issue has been resolved, because I kind of hijacked this issue.

LordGaav commented on issue vikunja/vikunja#966 2021-12-15 10:52:30 +00:00
Vikunja only requests openid scope when authenticating with Authentik

It was really only an issue going from 0.17 to 0.18.x for me, because OIDC was broken in 0.17. The fix you applied in vikunja/frontend#966 also fixes the underlying issue…

LordGaav commented on pull request vikunja/frontend#966 2021-11-10 22:26:13 +00:00
Properly return 404 when the file does not exist

I did not actually find any mp3 files in the deployed Docker container, this list is all the extensions that I did find.

LordGaav commented on pull request vikunja/frontend#966 2021-11-10 21:39:30 +00:00
Properly return 404 when the file does not exist

👌

LordGaav commented on pull request vikunja/frontend#966 2021-11-10 21:33:45 +00:00
Properly return 404 when the file does not exist

Indeed, see my latest commit. I applied this to my own installation, and everything still seems to work.

71ec28b590 Route all static files except HTML directly to disk or return 404
LordGaav commented on pull request vikunja/frontend#966 2021-11-10 21:13:13 +00:00
Properly return 404 when the file does not exist

Maybe we're going about this wrong; we want to avoid returning 200 OK on .js files because that breaks the service worker, any other route doesn't really matter.

LordGaav commented on pull request vikunja/frontend#966 2021-11-10 20:57:37 +00:00
Properly return 404 when the file does not exist

I see, you're right. Unfortunately, when serving with Nginx, the problem that I mentioned in the opening exists (serving 200 OK when actually it should be 404 Not Found).

Is there a way to…

LordGaav created pull request vikunja/frontend#966 2021-11-09 18:45:18 +00:00
Properly return 404 when the file does not exist
LordGaav created branch feature/do-not-return-200-on-every-request in LordGaav/frontend 2021-11-09 18:44:17 +00:00
f18d63f76d Properly return 404 when the file does not exist.
LordGaav created repository LordGaav/frontend 2021-11-09 18:42:14 +00:00
LordGaav commented on issue vikunja/vikunja#966 2021-11-09 18:38:55 +00:00
Vikunja only requests openid scope when authenticating with Authentik

I can reproduce it on my main PC with Firefox 94 on Ubuntu 20.04. When I 'just' opened Vikunja, it shows me that frontend 0.18.1 is loaded from the service worker. After clicking login, I get the…

LordGaav commented on issue vikunja/vikunja#966 2021-11-08 10:08:59 +00:00
Vikunja only requests openid scope when authenticating with Authentik

Ok, it gets weirder. This morning I tried to login from my work PC with Firefox 94 on Ubuntu 21.10, and it just worked. Checking the Network logs also shows that the right scopes get passed.

The…

LordGaav commented on issue vikunja/vikunja#966 2021-11-06 23:10:03 +00:00
Vikunja only requests openid scope when authenticating with Authentik

Can confirm that this issue happens with 0.18.1, with the same "No email address available. Please make sure the openid provider publicly provides an email address for your account." message. My…