Added register #13
No reviewers
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
Kind: Planning
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
question
Status: Abandoned
Status: Accepted
Status: Available
Status: Blocked
Status: Completed
Status: In Progress
Status: On Hold
Status: Pending
Status: Ready for Review
Status: Review Needed
Status: Revision Needed
Type: Bug
Type: Build
Type: Enhancement
Type: Maintenance
Type: Question
wontfix
No Milestone
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/app#13
Loading…
Reference in New Issue
No description provided.
Delete Branch "add-register"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why do you add
newRegisterService
instead of usingnewLoginService
?Because I want to register the user, not log him in...
But you can use the same service. LoginService could be provided for both. I see no reason in seperating it.
I've renamed it to
newUserService
and updated both register and login to use it, to avoid further confiusions. To me, it just doesn't make sense something callednewLoginService
can register users.Please move the validation of passwords to validate by setting password when onChanged is called.
Fixed. But in my tests, none of the private variables holding user informations are updated (the debugger show all of them are
null
), meaning validation and registering are failingYou have to update it via setState