vikunja/app
Archived
6
1
Fork 1
Code Issues 4 Pull Requests 11 Releases Wiki Activity

Added register #13

Merged
JonasFranz merged 21 commits from add-register into master 2018-10-08 14:26:01 +00:00
Conversation 7 Commits 21 Files Changed 7 +199 -9
konrad commented 2018-10-02 11:50:25 +00:00
Owner
Copy Link
No description provided.
JonasFranz was assigned by konrad 2018-10-02 11:50:25 +00:00
JonasFranz commented 2018-10-02 13:30:41 +00:00
Collaborator
Copy Link

Why do you add newRegisterService instead of using newLoginService?

Why do you add `newRegisterService` instead of using `newLoginService`?
konrad commented 2018-10-02 15:51:30 +00:00
Author
Owner
Copy Link

Because I want to register the user, not log him in...

Because I want to register the user, not log him in...
JonasFranz commented 2018-10-02 16:57:13 +00:00
Collaborator
Copy Link

But you can use the same service. LoginService could be provided for both. I see no reason in seperating it.

But you can use the same service. LoginService could be provided for both. I see no reason in seperating it.
konrad commented 2018-10-03 17:48:17 +00:00
Author
Owner
Copy Link

I've renamed it to newUserService and updated both register and login to use it, to avoid further confiusions. To me, it just doesn't make sense something called newLoginService can register users.

I've renamed it to `newUserService` and updated both register and login to use it, to avoid further confiusions. To me, it just doesn't make sense something called `newLoginService` can register users.
JonasFranz commented 2018-10-04 06:03:07 +00:00
Collaborator
Copy Link

Please move the validation of passwords to validate by setting password when onChanged is called.

Please move the validation of passwords to validate by setting password when onChanged is called.
konrad commented 2018-10-04 19:54:28 +00:00
Author
Owner
Copy Link

Fixed. But in my tests, none of the private variables holding user informations are updated (the debugger show all of them are null), meaning validation and registering are failing

Fixed. But in my tests, none of the private variables holding user informations are updated (the debugger show all of them are `null`), meaning validation and registering are failing
JonasFranz commented 2018-10-05 12:07:22 +00:00
Collaborator
Copy Link

You have to update it via setState

You have to update it via setState
JonasFranz added the
Status: Completed
Type: Enhancement
 labels 2018-10-08 14:05:14 +00:00
JonasFranz closed this pull request 2018-10-08 14:26:01 +00:00
JonasFranz deleted branch add-register 2018-10-08 14:26:20 +00:00
JonasFranz referenced this issue from a commit 2018-10-08 14:31:47 +00:00
Added register (#13)
konrad added this to the 0.1 milestone 2019-03-16 15:42:02 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
Kind: Planning
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
question
Status: Abandoned
Status: Accepted
Status: Available
Status: Blocked
Status: Completed
Status: In Progress
Status: On Hold
Status: Pending
Status: Ready for Review
Status: Review Needed
Status: Revision Needed
Type: Bug
Type: Build
Type: Enhancement
Type: Maintenance
Type: Question
wontfix
No Label
Status: Completed
Type: Enhancement
Milestone
No items
No Milestone 0.1
Assignees
Clear assignees
JonasFranz konrad lawless renovate
No Assignees JonasFranz
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/app#13
No description provided.
Delete Branch "add-register"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?