Added register #13

konrad · 2018-10-02T11:50:25Z

konrad commented

2018-10-02 11:50:25 +00:00

No description provided.

JonasFranz was assigned by konrad

2018-10-02 11:50:25 +00:00

JonasFranz commented

2018-10-02 13:30:41 +00:00

Why do you add newRegisterService instead of using newLoginService?

Why do you add `newRegisterService` instead of using `newLoginService`?

konrad commented

2018-10-02 15:51:30 +00:00

Because I want to register the user, not log him in...

JonasFranz commented

2018-10-02 16:57:13 +00:00

But you can use the same service. LoginService could be provided for both. I see no reason in seperating it.

konrad commented

2018-10-03 17:48:17 +00:00

I've renamed it to newUserService and updated both register and login to use it, to avoid further confiusions. To me, it just doesn't make sense something called newLoginService can register users.

I've renamed it to `newUserService` and updated both register and login to use it, to avoid further confiusions. To me, it just doesn't make sense something called `newLoginService` can register users.

JonasFranz commented

2018-10-04 06:03:07 +00:00

Please move the validation of passwords to validate by setting password when onChanged is called.

konrad commented

2018-10-04 19:54:28 +00:00

Fixed. But in my tests, none of the private variables holding user informations are updated (the debugger show all of them are null), meaning validation and registering are failing

Fixed. But in my tests, none of the private variables holding user informations are updated (the debugger show all of them are `null`), meaning validation and registering are failing

JonasFranz commented

2018-10-05 12:07:22 +00:00

You have to update it via setState

JonasFranz added the

Status: Completed

Type: Enhancement

labels 2018-10-08 14:05:14 +00:00

JonasFranz closed this pull request

2018-10-08 14:26:01 +00:00

JonasFranz deleted branch add-register

2018-10-08 14:26:20 +00:00

JonasFranz referenced this issue from a commit