vikunja/app
Archived
6
1
Fork 1
Code Issues 4 Pull Requests 11 Releases Wiki Activity

Theme update #23

Merged
JonasFranz merged 9 commits from featuer/theme into master 2019-03-11 20:38:06 +00:00
Conversation 3 Commits 9 Files Changed 12 +203 -63
konrad commented 2019-03-10 20:57:23 +00:00
Owner
Copy Link

Theme update to have the theme closer to the web app.

Theme update to have the theme closer to the web app.
JonasFranz was assigned by konrad 2019-03-10 20:57:23 +00:00
JonasFranz reviewed 2019-03-11 20:33:10 +00:00
lib/pages/list_page.dart Outdated
@ -97,3 +97,3 @@
onAdd: _addItem,
decoration: new InputDecoration(
labelText: 'List Item', hintText: 'eg. Milk')));
labelText: 'Task name', hintText: 'eg. Milk')));
JonasFranz commented 2019-03-11 20:32:48 +00:00
Collaborator

We should name this Task Name since this a kind of title.

We should name this `Task Name` since this a kind of title.
konrad commented 2019-03-11 20:36:43 +00:00
Author
Owner

Done.

Done.
lib/theme/variables.dart
@ -0,0 +1,25 @@
import 'package:flutter/material.dart';
JonasFranz commented 2019-03-11 20:30:38 +00:00
Collaborator

Maybe rename it to constants

Maybe rename it to constants
konrad commented 2019-03-11 20:36:50 +00:00
Author
Owner

Done.

Done.
JonasFranz commented 2019-03-11 20:36:05 +00:00
Collaborator
Copy Link

Otherwise lgtm

Otherwise lgtm
JonasFranz added the
Type: Enhancement
Status: Accepted
 labels 2019-03-11 20:36:46 +00:00
JonasFranz approved these changes 2019-03-11 20:38:02 +00:00
JonasFranz closed this pull request 2019-03-11 20:38:06 +00:00
JonasFranz deleted branch featuer/theme 2019-03-11 20:38:10 +00:00
konrad added this to the 0.1 milestone 2019-03-16 15:41:41 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
JonasFranz
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
Kind: Planning
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
question
Status: Abandoned
Status: Accepted
Status: Available
Status: Blocked
Status: Completed
Status: In Progress
Status: On Hold
Status: Pending
Status: Ready for Review
Status: Review Needed
Status: Revision Needed
Type: Bug
Type: Build
Type: Enhancement
Type: Maintenance
Type: Question
wontfix
No Label
Status: Accepted
Type: Enhancement
Milestone
No items
No Milestone 0.1
Assignees
Clear assignees
JonasFranz konrad lawless renovate
No Assignees JonasFranz
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/app#23
No description provided.
Delete Branch "featuer/theme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?