vikunja/app
Archived
6
1
Fork 1
Code Issues 4 Pull Requests 11 Releases Wiki Activity

Show a message if a list or namespace is empty #29

Merged
JonasFranz merged 13 commits from improvement/show-empty-notice into master 2019-03-18 17:05:32 +00:00
Conversation 4 Commits 13 Files Changed 4 +57 -38
konrad commented 2019-03-14 18:01:04 +00:00
Owner
Copy Link

Blocked by #28

Blocked by #28
JonasFranz was assigned by konrad 2019-03-14 18:01:09 +00:00
konrad added the
Status: Blocked
 label 2019-03-14 18:01:58 +00:00
JonasFranz added a new dependency 2019-03-14 20:32:11 +00:00
#22 Todo
konrad removed the
Status: Blocked
 label 2019-03-15 06:42:56 +00:00
konrad commented 2019-03-15 06:43:50 +00:00
Author
Owner
Copy Link

#28 is merged, I resolved some problems it carried in. This can be merged now.

#28 is merged, I resolved some problems it carried in. This can be merged now.
konrad added the
Status: Ready for Review
 label 2019-03-15 06:57:20 +00:00
JonasFranz requested changes 2019-03-18 15:27:05 +00:00
lib/pages/list/list.dart
@ -59,3 +57,1 @@
context: context, tiles: _listTasks())
.toList(),
),
child: _hasTasks
JonasFranz commented 2019-03-18 15:26:33 +00:00
Collaborator

Replace _hasTasks with the definition below.

Replace `_hasTasks` with the definition below.
JonasFranz added
Status: Revision Needed
 and removed
Status: Ready for Review
 labels 2019-03-18 15:28:10 +00:00
konrad added
Status: Review Needed
 and removed
Status: Revision Needed
 labels 2019-03-18 16:52:15 +00:00
JonasFranz requested changes 2019-03-18 16:59:12 +00:00
lib/pages/namespace/namespace.dart Outdated
@ -85,6 +96,8 @@ class _NamespacePageState extends State<NamespacePage>
.then((lists) => setState(() {
this._lists = lists;
this._loading = false;
// _hasTasks = list.tasks != null ? list.tasks.length > 0 : false;
JonasFranz commented 2019-03-18 16:59:09 +00:00
Collaborator

Remove comment and _hasList

Remove comment and `_hasList`
konrad added this to the 0.1 milestone 2019-03-18 17:00:22 +00:00
JonasFranz approved these changes 2019-03-18 17:05:28 +00:00
JonasFranz closed this pull request 2019-03-18 17:05:32 +00:00
konrad deleted branch improvement/show-empty-notice 2019-03-18 17:16:20 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
JonasFranz
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
Kind: Planning
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
question
Status: Abandoned
Status: Accepted
Status: Available
Status: Blocked
Status: Completed
Status: In Progress
Status: On Hold
Status: Pending
Status: Ready for Review
Status: Review Needed
Status: Revision Needed
Type: Bug
Type: Build
Type: Enhancement
Type: Maintenance
Type: Question
wontfix
No Label
Status: Review Needed
Milestone
No items
No Milestone 0.1
Assignees
Clear assignees
No Assignees JonasFranz
2 Participants
Due Date
No due date set.
Blocks
#22 Todo
vikunja/app
Reference: vikunja/app#29
No description provided.
Delete Branch "improvement/show-empty-notice"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?