vikunja
/
desktop
Archived
2
3
Fork 2
Code Issues 7 Pull Requests 1 Releases 2 Wiki Activity

Add io.vikunja.Vikunja.appdata.xml and io.vikunja.Vikunja.desktop #162

Closed
RaptaG wants to merge 3 commits from (deleted):main into main
pull from: (deleted):main
merge into: vikunja:main
Conversation 10 Commits 3 Files Changed 2 +25
RaptaG commented 2023-07-10 17:38:45 +00:00
First-time contributor
Copy Link

Per https://github.com/flathub/flathub/pull/4319#discussion_r1258602996

Signed-off-by: RaptaG sir-raptag@tutamail.com

Per https://github.com/flathub/flathub/pull/4319#discussion_r1258602996 Signed-off-by: RaptaG <sir-raptag@tutamail.com>
RaptaG added 1 commit 2023-07-10 17:38:46 +00:00
konrad commented 2023-07-10 17:42:45 +00:00
Owner
Copy Link

Can you check how we can tell electron builder to use this? IIRC they already to this?

Check out https://www.electron.build/configuration/linux with the desktop option iirc

Can you check how we can tell electron builder to use this? IIRC they already to this? Check out https://www.electron.build/configuration/linux with the `desktop` option iirc
RaptaG commented 2023-07-10 17:44:56 +00:00
Author
First-time contributor
Copy Link

target = flatpak is a start I think

`target = flatpak` is a start I think
konrad commented 2023-07-10 17:46:43 +00:00
Owner
Copy Link

what do we get if we add this? IIRC it will only produce a bundle installable with the flatpack cli but nothing we can use to add this to flathub (as they build everything themselves)

what do we get if we add this? IIRC it will only produce a bundle installable with the `flatpack` cli but nothing we can use to add this to flathub (as they build everything themselves)
RaptaG commented 2023-07-10 17:51:22 +00:00
Author
First-time contributor
Copy Link

🤷‍♂️

:man_shrugging:
RaptaG commented 2023-07-10 17:52:51 +00:00
Author
First-time contributor
Copy Link

I'll work on this later

I'll work on this later
👍 1
RaptaG added 1 commit 2023-07-11 14:26:39 +00:00
46b5eecc63
Add a .desktop file 
Signed-off-by: RaptaG <sir-raptag@tutamail.com>
RaptaG changed title from Add io.vikunja.Vikunja.appdata.xml to Add io.vikunja.Vikunja.appdata.xml and io.vikunja.Vikunja.desktop 2023-07-11 14:27:21 +00:00
RaptaG commented 2023-07-11 16:33:35 +00:00
Author
First-time contributor
Copy Link

@konrad the .tar.gz does not have an icon.png inside of it. What should I do?

@konrad the `.tar.gz` does not have an icon.png inside of it. What should I do?
konrad reviewed 2023-07-11 16:35:19 +00:00
io.vikunja.Vikunja.desktop
@ -0,0 +6,4 @@
Category=Utility;Accessories;
Keywords=todo;task;
Icon=
Exec=flatpak run io.vikunja.Vikunja
konrad commented 2023-07-11 16:35:19 +00:00
Owner

If this is specific to flatpack, we should not include it here but in the flathub build repo.

If this is specific to flatpack, we should not include it here but in the flathub build repo.
RaptaG commented 2023-07-11 16:42:27 +00:00
Author
First-time contributor

If this is specific to flatpack, we should not include it here but in the flathub build repo.

We can only use resource available inside the archive, all processes are done offline

> If this is specific to flatpack, we should not include it here but in the flathub build repo. We can only use resource available inside the archive, all processes are done offline
konrad commented 2023-07-11 17:15:07 +00:00
Owner

But we're including the sh wrapper as well? Couldn't we add the .desktop file in a similar manner?

But we're including the sh wrapper as well? Couldn't we add the `.desktop` file in a similar manner?
konrad commented 2023-07-11 16:36:12 +00:00
Owner
Copy Link

@konrad the .tar.gz does not have an icon.png inside of it. What should I do?

mhh I think the icon is bundled in the .asar file but there's no way we'll get it out there during the flatpack build process. Probably best to add it seperately.

> @konrad the `.tar.gz` does not have an icon.png inside of it. What should I do? mhh I *think* the icon is bundled in the `.asar` file but there's no way we'll get it out there during the flatpack build process. Probably best to add it seperately.
RaptaG commented 2023-07-11 17:57:18 +00:00
Author
First-time contributor
Copy Link

We might include these inside the Flathub repo (I hope)

We might include these inside the Flathub repo (I hope)
👍 1
RaptaG added 1 commit 2023-07-11 17:58:04 +00:00
1517cec335
Add the icon 
Signed-off-by: RaptaG <sir-raptag@tutamail.com>
RaptaG commented 2023-07-12 11:29:47 +00:00
Author
First-time contributor
Copy Link

Pushed on the Flathub repo 🎉 which now works!!

Pushed on the Flathub repo :tada: which now works!!
🎉 1
RaptaG closed this pull request 2023-07-12 11:29:51 +00:00
konrad commented 2023-07-13 06:47:56 +00:00
Owner
Copy Link

Wow, thanks a lot!

Wow, thanks a lot!
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
blocked by upstream

   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/feature

New feature

  
kind/ux

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
blocked by upstream
bug
duplicate
help wanted
invalid
kind/feature
kind/ux
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/desktop#162
No description provided.
Delete Branch "(deleted):main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?