feat: restyle unauthenticated screens #1103
|
@ -3,7 +3,7 @@
|
|||
<Logo class="logo" width="200" height="58"/>
|
||||
<div class="noauth-container">
|
||||
<section class="image">
|
||||
<div class="overlay">
|
||||
<div class="overlay" :class="{'has-message': motd !== ''}">
|
||||
<message v-if="motd !== ''">
|
||||
{{ motd }}
|
||||
</message>
|
||||
|
@ -14,7 +14,6 @@
|
|||
</section>
|
||||
<section class="content">
|
||||
<slot/>
|
||||
|
||||
<legal/>
|
||||
</section>
|
||||
</div>
|
||||
|
@ -62,15 +61,19 @@ const motd = computed(() => store.state.config.motd)
|
|||
|
||||
konrad marked this conversation as resolved
Outdated
|
||||
.overlay {
|
||||
padding: 1rem;
|
||||
display: flex;
|
||||
justify-content: space-between;
|
||||
flex-direction: column;
|
||||
position: absolute;
|
||||
top: 0;
|
||||
left: 0;
|
||||
right: 0;
|
||||
bottom: 0;
|
||||
background: rgba(0, 0, 0, .2);
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
justify-content: end;
|
||||
|
||||
&.has-message {
|
||||
konrad marked this conversation as resolved
dpschen
commented
Move these rules to the
Move media queries before If you change Move these rules to the `@media screen and (min-width: $tablet)` media query
=> makes it clearer that it just appies there.
```scss
width: 50%;
padding: 1rem;
display: flex;
flex-direction: column;
justify-content: flex-end;
&::after {
content: '';
position: absolute;
top: 0;
left: 0;
right: 0;
bottom: 0;
background-color: rgba(0, 0, 0, .2);
z-index: 10;
}
> * {
z-index: 20;
}
```
Move media queries before `&::after` and `> *`
=> those are styling other elements
=> move styles together that style the same stuff
If you change `&::after` in `&::before` you can remove the z-index if you replace
`z-index: 20;` with `position: relative` (this creates a new [stacking context](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/The_stacking_context).
=> less complexity with managing z-index.
konrad
commented
Done! Done!
|
||||
justify-content: space-between;
|
||||
}
|
||||
}
|
||||
|
||||
.content {
|
||||
|
|
Reference in New Issue
Use mobile first:
Compress image and load with something like https://github.com/JonasKruckenberg/imagetools
With the vite wrapper and use it for other images as well?
Yes. But maybe let's move this to a new issue.
yeah I think we should.