vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: restyle unauthenticated screens #1103

Merged
dpschen merged 29 commits from feature/login-pages into main 2021-12-12 16:40:14 +00:00
Conversation 12 Commits 29 Files Changed 10 +12 -12
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 498ecc7505 - Show all commits

24
src/components/misc/no-auth-wrapper.vue
View File

@ -50,28 +50,28 @@ const motd = computed(() => store.state.config.motd)
min-height: 60vh;
display: flex;
background-color: var(--white);
konrad marked this conversation as resolved Outdated
dpschen commented 2021-12-09 17:42:17 +00:00
Outdated
Review
Copy Link

Why overflow: hidden?

Why overflow: hidden?
konrad commented 2021-12-11 17:29:25 +00:00
Outdated
Review
Copy Link

To prevent the background from overflowing in the (rounded) corners.

To prevent the background from overflowing in the (rounded) corners.
border-radius: $radius;
box-shadow: var(--shadow-md);
overflow: hidden;
konrad marked this conversation as resolved Outdated
dpschen commented 2021-12-09 17:40:19 +00:00
Outdated
Review
Copy Link

Use mobile first:

	@media screen and (min-width: $desktop) {
    		border-radius: $radius;
    }

=> no need to reset the border-radius for mobile

Use mobile first: ```scss @media screen and (min-width: $desktop) { border-radius: $radius; } ``` => no need to reset the border-radius for mobile
konrad marked this conversation as resolved Outdated
dpschen commented 2021-12-12 13:41:40 +00:00
Outdated
Review
Copy Link

Just checked this: The llama is so nice, it's too bad it's not visivle on mobile. How about adding a padding-bottom for mobile?

Just checked this: The llama is so nice, it's too bad it's not visivle on mobile. How about adding a padding-bottom for mobile?
konrad commented 2021-12-12 13:54:40 +00:00
Outdated
Review
Copy Link

done!

done!
🎉 1
@media screen and (max-width: $desktop) {
border-radius: 0;
@media screen and (min-width: $desktop) {
border-radius: $radius;
}
}
.image {
konrad marked this conversation as resolved Outdated
dpschen commented 2021-11-28 15:43:08 +00:00
Outdated
Review
Copy Link

Use mobile first:

.image {
    @media screen and (max-width: $tablet) {
        display: none;
    }
    @media screen and (min-width: $tablet) {
        width: 40%;
        background: url('@/assets/no-auth-image.jpg') no-repeat bottom/cover;
        position: relative;
    }
    @media screen and (min-width: $desktop) {
        width: 60%;
    }
}

Compress image and load with something like https://github.com/JonasKruckenberg/imagetools

Use mobile first: ```scss .image { @media screen and (max-width: $tablet) { display: none; } @media screen and (min-width: $tablet) { width: 40%; background: url('@/assets/no-auth-image.jpg') no-repeat bottom/cover; position: relative; } @media screen and (min-width: $desktop) { width: 60%; } } ``` Compress image and load with something like https://github.com/JonasKruckenberg/imagetools
konrad commented 2021-12-11 19:44:06 +00:00
Outdated
Review
Copy Link

Compress image and load with something like https://github.com/JonasKruckenberg/imagetools

With the vite wrapper and use it for other images as well?

> Compress image and load with something like https://github.com/JonasKruckenberg/imagetools With the vite wrapper and use it for other images as well?
dpschen commented 2021-12-12 15:02:55 +00:00
Outdated
Review
Copy Link

Yes. But maybe let's move this to a new issue.

Yes. But maybe let's move this to a new issue.
👍 1
konrad commented 2021-12-12 15:03:23 +00:00
Outdated
Review
Copy Link

yeah I think we should.

yeah I think we should.
width: 60%;
background: url('@/assets/no-auth-image.jpg') no-repeat bottom;
background-size: cover;
position: relative;
@media screen and (max-width: $desktop) {
width: 40%;
}
@media screen and (max-width: $tablet) {
display: none;
}
@media screen and (min-width: $tablet) {
width: 40%;
background: url('@/assets/no-auth-image.jpg') no-repeat bottom/cover;
position: relative;
}
@media screen and (min-width: $desktop) {
width: 60%;
}
konrad marked this conversation as resolved
dpschen commented 2021-12-12 14:14:07 +00:00
Review
Copy Link

Move these rules to the @media screen and (min-width: $tablet) media query
=> makes it clearer that it just appies there.

	width: 50%;
	padding: 1rem;
	display: flex;
	flex-direction: column;
	justify-content: flex-end;
    
	&::after {
		content: '';
		position: absolute;
		top: 0;
		left: 0;
		right: 0;
		bottom: 0;
		background-color: rgba(0, 0, 0, .2);
		z-index: 10;
	}

	> * {
		z-index: 20;
	}

Move media queries before &::after and > *
=> those are styling other elements
=> move styles together that style the same stuff

If you change &::after in &::before you can remove the z-index if you replace
z-index: 20; with position: relative (this creates a new stacking context.
=> less complexity with managing z-index.

Move these rules to the `@media screen and (min-width: $tablet)` media query => makes it clearer that it just appies there. ```scss width: 50%; padding: 1rem; display: flex; flex-direction: column; justify-content: flex-end; &::after { content: ''; position: absolute; top: 0; left: 0; right: 0; bottom: 0; background-color: rgba(0, 0, 0, .2); z-index: 10; } > * { z-index: 20; } ``` Move media queries before `&::after` and `> *` => those are styling other elements => move styles together that style the same stuff If you change `&::after` in `&::before` you can remove the z-index if you replace `z-index: 20;` with `position: relative` (this creates a new [stacking context](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/The_stacking_context). => less complexity with managing z-index.
konrad commented 2021-12-12 14:52:53 +00:00
Review
Copy Link

Done!

Done!
}
.overlay {