vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: restyle unauthenticated screens #1103

Merged
dpschen merged 29 commits from feature/login-pages into main 2021-12-12 16:40:14 +00:00
Conversation 12 Commits 29 Files Changed 10 +10 -2
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit bc023d25ea - Show all commits

12
src/components/misc/message.vue
View File

@ -1,6 +1,8 @@
<template>
<div class="message" :class="variant">
<slot/>
<div class="message-wrapper">
<div class="message" :class="variant">
<slot/>
</div>
</div>
</template>
@ -14,6 +16,12 @@ defineProps({
</script>
<style lang="scss" scoped>
.message-wrapper {
border-radius: $radius;
background: var(--white);
overflow: hidden;
konrad marked this conversation as resolved
dpschen commented 2021-11-28 15:00:32 +00:00
Review
Copy Link

  • I don't get the need for the new wrapper.

  • What's the overflow for?

- I don't get the need for the new wrapper. - What's the `overflow` for?
konrad commented 2021-12-11 17:26:16 +00:00
Review
Copy Link

That's because the message background is transparent. When I put the message on something with a background, it would shine through. The overlay puts a white background behind it so the message background color is always the same.

I just realized I don't need the overflow so I just removed it.

That's because the message background is transparent. When I put the message on something with a background, it would shine through. The overlay puts a white background behind it so the message background color is always the same. I just realized I don't need the overflow so I just removed it.
👍 1
}
.message {
padding: .75rem 1rem;
border-radius: $radius;