vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: restyle unauthenticated screens #1103

Merged
dpschen merged 29 commits from feature/login-pages into main 2021-12-12 16:40:14 +00:00
Conversation 12 Commits 29 Files Changed 10 -1
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fc8321df6b - Show all commits

1
src/components/misc/no-auth-wrapper.vue
View File

@ -101,7 +101,6 @@ const motd = computed(() => store.state.config.motd)
}
.logo {
dpschen marked this conversation as resolved Outdated
dpschen commented 2021-12-09 18:17:56 +00:00
Outdated
Review
Copy Link

On desktop:
Maybe the logo should be not centered but left aligned with the content below.
=> Might make the Title easier to read because there is more room between those two headlines

On desktop: Maybe the logo should be not centered but left aligned with the content below. => Might make the Title easier to read because there is more room between those two headlines
konrad commented 2021-12-11 19:34:06 +00:00
Outdated
Review
Copy Link

You mean aligned in the middle like this?

You mean aligned in the middle like this?
konrad commented 2021-12-11 19:35:38 +00:00
Outdated
Review
Copy Link

Okay wow I can't put images in a comment here, here's the screenshot I wanted to post:

Okay wow I can't put images in a comment here, here's the screenshot I wanted to post: ![](https://kolaente.dev/attachments/1847041a-d987-46e1-9d70-99c5745e8306)
dpschen commented 2021-12-12 15:15:44 +00:00
Outdated
Review
Copy Link

I'm also not really happy with this. Let's keep it for now how it is.

I'm also not really happy with this. Let's keep it for now how it is.
color: var(--logo-text-color);
max-width: 100%;
konrad marked this conversation as resolved Outdated
dpschen commented 2021-12-09 17:59:46 +00:00
Outdated
Review
Copy Link

Color seems to be applied twice (from inside the component aswell).

Color seems to be applied twice (from inside the component aswell).
margin: 1rem 0;
}
konrad marked this conversation as resolved Outdated
dpschen commented 2021-12-09 18:01:28 +00:00
Outdated
Review
Copy Link

Picky: new css love: use margin-block: 1rem; => transformed by postcss-preset-env. Reason: you don't want to define the inline (left, right) value, but do it here as a sideeffect.

Picky: new css love: use `margin-block: 1rem;` => transformed by postcss-preset-env. Reason: you don't want to define the inline (left, right) value, but do it here as a sideeffect.
konrad commented 2021-12-11 19:52:42 +00:00
Outdated
Review
Copy Link

hmm it looks like this isn't transformed. But it definitely is a nice propery.

hmm it looks like this isn't transformed. But it definitely is a nice propery.
dpschen commented 2021-12-12 14:45:31 +00:00
Outdated
Review
Copy Link

I checked this again.

I think that the browsers that we want to support according to our browserslist all support it natively so there is no need for postcss-preset-env to transform it =)

Because it does do that via postcss-logical

I checked this again. I think that the browsers that we want to support according to our browserslist all support it natively so there is no need for postcss-preset-env to transform it =) Because it does do that via [postcss-logical](https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-logical)
👍 1