vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: improve login and register ux #1104

Merged
dpschen merged 23 commits from feature/login-improvements into main 2022-02-05 17:22:43 +00:00
Conversation 3 Commits 23 Files Changed 13 +13 -3
3 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fda0b81d9c - Show all commits

4
src/i18n/lang/en.json
View File

@ -52,7 +52,9 @@
"logout": "Logout",
"emailInvalid": "Please enter a valid email address.",
konrad marked this conversation as resolved Outdated
dpschen commented 2021-12-10 11:13:34 +00:00
Outdated
Review
Copy Link

Email is written inconsistent in English: sometimes it's "E-mail" sometimes "Email".
The more common one seems to be "Email" (more google results and wiki article's main spelling).

Email is written inconsistent in English: sometimes it's "E-mail" sometimes "Email". The more common one seems to be "Email" (more google results and wiki article's main spelling).
konrad commented 2021-12-11 20:38:47 +00:00
Outdated
Review
Copy Link

Changed it so that it's consistent everywhere.

Changed it so that it's consistent everywhere.
"usernameRequired": "Please provide a username.",
"passwordRequired": "Please provide a password."
"passwordRequired": "Please provide a password.",
"showPassword": "Show the password",
"hidePassword": "Hide the password"
},
"settings": {
"title": "Settings",

6
src/views/user/Login.vue
View File

@ -53,7 +53,11 @@
tabindex="2"
@focusout="validateField('password')"
/>
konrad marked this conversation as resolved Outdated
dpschen commented 2021-12-10 11:19:57 +00:00
Outdated
Review
Copy Link

Add aria-label and tooltip

Add aria-label and tooltip
konrad commented 2021-12-11 20:58:02 +00:00
Outdated
Review
Copy Link

Done.

Done.
<a @click="togglePasswordFieldType" class="password-field-type-toggle">
<a
@click="togglePasswordFieldType"
class="password-field-type-toggle"
aria-label="passwordFieldType === 'password' ? $t('user.auth.showPassword') : $t('user.auth.hidePassword')"
v-tooltip="passwordFieldType === 'password' ? $t('user.auth.showPassword') : $t('user.auth.hidePassword')">
<icon :icon="passwordFieldType === 'password' ? 'eye' : 'eye-slash'"/>
</a>
</div>

6
src/views/user/Register.vue
View File

@ -59,7 +59,11 @@
@keyup.enter="submit"
@focusout="validatePassword"
/>
<a @click="togglePasswordFieldType" class="password-field-type-toggle">
<a
@click="togglePasswordFieldType"
class="password-field-type-toggle"
aria-label="passwordFieldType === 'password' ? $t('user.auth.showPassword') : $t('user.auth.hidePassword')"
v-tooltip="passwordFieldType === 'password' ? $t('user.auth.showPassword') : $t('user.auth.hidePassword')">
<icon :icon="passwordFieldType === 'password' ? 'eye' : 'eye-slash'"/>
</a>
</div>