vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: replace our home-grown gantt implementation with ganttastic #2180

Merged
konrad merged 78 commits from feature/ganttastic into main 2022-10-27 16:03:27 +00:00
Conversation 41 Commits 78 Files Changed 48 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5f7159ebc4 - Show all commits

2
src/views/list/ListGantt.vue
View File

@ -77,7 +77,7 @@ const precision = ref('day')
const now = ref(new Date())
konrad marked this conversation as resolved Outdated
dpschen commented 2022-07-21 22:57:18 +00:00
Outdated
Review
Copy Link

Should this update?

Should this update?
konrad commented 2022-08-02 11:59:05 +00:00
Outdated
Review
Copy Link

No, doesn't even need to be ref.

No, doesn't even need to be ref.
const defaultFrom = format(new Date((new Date()).setDate(now.value.getDate() - 15)), 'yyyy-LL-dd')
const defaultTo = format(new Date((new Date()).setDate(now.value.getDate() + 30)), 'yyyy-LL-dd')
const defaultTo = format(new Date((new Date()).setDate(now.value.getDate() + 55)), 'yyyy-LL-dd')
const range = ref(`${defaultFrom} to ${defaultTo}`)
// TODO: only update once both dates are available (maybe use a watcher + refs instead?)
dpschen commented 2022-07-21 22:57:36 +00:00
Outdated
Review
Copy Link

Can you explain in a different way?

Can you explain in a different way?
konrad commented 2022-08-02 12:01:54 +00:00
Outdated
Review
Copy Link

The problem is the gantt chart already updates when only one date (the start or end date) is selected. Ideally, they would only update the prop when both of these dates are available to avoid these partial updates.

The problem is the gantt chart already updates when only one date (the start or end date) is selected. Ideally, they would only update the prop when both of these dates are available to avoid these partial updates.
dpschen commented 2022-08-04 18:46:02 +00:00
Outdated
Review
Copy Link

Maybe I'm still not getting this correctly, but can't we just update the value when both (start and end) are set?

Maybe I'm still not getting this correctly, but can't we just update the value when both (start and end) are set?
konrad commented 2022-08-04 20:46:56 +00:00
Outdated
Review
Copy Link

Currently the from and to dates get passed as individual props. That means if one changes, it changes directly in the chart.

I think the way to go here would be to pass a single object with both dates instead?

Currently the from and to dates get passed as individual props. That means if one changes, it changes directly in the chart. I think the way to go here would be to pass a single object with both dates instead?
👍 1
dpschen commented 2022-09-08 16:03:32 +00:00
Outdated
Review
Copy Link

That seems like the right approach

That seems like the right approach
dpschen commented 2022-10-07 11:48:35 +00:00
Outdated
Review
Copy Link

Will check this out again. Shouldn't be too hard.

Will check this out again. Shouldn't be too hard.