vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: replace our home-grown gantt implementation with ganttastic #2180

Merged
konrad merged 78 commits from feature/ganttastic into main 2022-10-27 16:03:27 +00:00
Conversation 41 Commits 78 Files Changed 48 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6975a2b286 - Show all commits

4
src/components/tasks/gantt-chart.vue
View File

@ -185,11 +185,11 @@ async function updateTask(e) {
task.startDate = e.bar.startDate
task.endDate = e.bar.endDate
const r = await taskService.value.update(task)
konrad marked this conversation as resolved Outdated
dpschen commented 2022-07-21 22:46:01 +00:00
Outdated
Review
Copy Link

Avoid for ... in, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in#array_iteration_and_for...in

Avoid `for ... in`, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in#array_iteration_and_for...in
konrad commented 2022-08-02 12:03:46 +00:00
Outdated
Review
Copy Link

Done.

Done.
👍 1
for (const i in ganttBars.value) {
ganttBars.value.forEach((el, i) => {
if (ganttBars.value[i][0].ganttBarConfig.id === task.id) {
ganttBars.value[i] = transformTaskToGanttBar(r)
}
}
})
}
const newTaskFieldActive = ref(false)
konrad marked this conversation as resolved Outdated
dpschen commented 2022-07-21 22:47:27 +00:00
Outdated
Review
Copy Link

Add type: https://vuejs.org/guide/typescript/composition-api.html#typing-template-refs

Add type: https://vuejs.org/guide/typescript/composition-api.html#typing-template-refs
konrad commented 2022-08-02 12:04:00 +00:00
Outdated
Review
Copy Link

Done.

Done.
👍 1