vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: replace our home-grown gantt implementation with ganttastic #2180

Merged
konrad merged 78 commits from feature/ganttastic into main 2022-10-27 16:03:27 +00:00
Conversation 41 Commits 78 Files Changed 48 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d3925b8d80 - Show all commits

2
src/components/tasks/gantt-chart.vue
View File

@ -60,7 +60,7 @@ import TaskService from '@/services/task'
import {format, parse} from 'date-fns'
import {colorIsDark} from '@/helpers/color/colorIsDark'
import {useStore} from 'vuex'
konrad marked this conversation as resolved Outdated
dpschen commented 2022-07-21 22:59:47 +00:00
Outdated
Review
Copy Link

Picky: Use @/models...

Picky: Use `@/models...`
konrad commented 2022-08-02 12:02:32 +00:00
Outdated
Review
Copy Link

Done.

Done.
🎉 1
import Rights from '../../models/constants/rights.json'
import Rights from '@/models/constants/rights.json'
import TaskModel from '@/models/task'
import {useRouter} from 'vue-router'
import Loading from '@/components/misc/loading.vue'
konrad marked this conversation as resolved Outdated
dpschen commented 2022-07-21 22:25:35 +00:00
Outdated
Review
Copy Link

picky: use DATE_FORMAT to make clear it's a 'config const'

picky: use `DATE_FORMAT` to make clear it's a 'config const'
dpschen commented 2022-07-21 22:26:04 +00:00
Outdated
Review
Copy Link

But also: shouldn't this depend on the user setting / language?

But also: shouldn't this depend on the user setting / language?
konrad commented 2022-08-02 11:47:35 +00:00
Outdated
Review
Copy Link

shouldn't this depend on the user setting / language?

It's only used to pass the date in the correct format to the gantt chart libaray so it will always be the same. Not sure why they only take strings as input instead of Date objects but that's how it is.

> shouldn't this depend on the user setting / language? It's only used to pass the date in the correct format to the gantt chart libaray so it will always be the same. Not sure why they only take strings as input instead of `Date` objects but that's how it is.
👍 1