vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat(list): add info dialoge to show list description #2368

Merged
konrad merged 6 commits from feature/list-description into main 2022-09-15 12:36:44 +00:00
Conversation 6 Commits 6 Files Changed 9 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6e0e4f8f35 - Show all commits

2
src/router/index.ts
View File

@ -344,7 +344,7 @@ const router = createRouter({
meta: {
showAsModal: true,
},
props: route => ({ listId: parseInt(route.params.listId as string) }),
props: route => ({ listId: Number(route.params.listId as string) }),
konrad marked this conversation as resolved Outdated
dpschen commented 2022-09-15 12:18:39 +00:00
Outdated
Review
Copy Link

Picky:
We should start to use Number() here instead (also in all the other route definitions).

Reason:
We currently don't define the radix parameter and parseInt(someVar, 10) is not as easy to read as Number(someVar).
That we start having problems with radix is very unlikely though.

Picky: We should start to use `Number()` here instead (also in all the other route definitions). Reason: We currently don't define the radix parameter and `parseInt(someVar, 10)` is not as easy to read as `Number(someVar)`. That we start having problems with radix is very unlikely though.
konrad commented 2022-09-15 12:29:08 +00:00
Outdated
Review
Copy Link

Makes sense. Changed it.

Makes sense. Changed it.
},
{
path: '/lists/:listId',