vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: rename lists to projects #2697

Closed
konrad wants to merge 53 commits from feature/rename-lists-to-projects into main
pull from: feature/rename-lists-to-projects
merge into: vikunja:main
Conversation 11 Commits 53 Files Changed 156 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 059e4643e6 - Show all commits

2
src/router/index.ts
View File

@ -356,7 +356,7 @@ const router = createRouter({
path: '/projects/:projectId',
name: 'project.index',
redirect(to) {
// Redirect the user to project view by default
// Redirect the user to list view by default
konrad marked this conversation as resolved Outdated
dpschen commented 2023-01-18 13:32:32 +00:00
Outdated
Review
Copy Link

This redirects indead to the list view!

This redirects indead to the `list` view!
const savedProjectView = getProjectView(to.params.projectId)
console.debug('Replaced project view with', savedProjectView)
konrad marked this conversation as resolved Outdated
dpschen commented 2023-01-18 13:33:11 +00:00
Outdated
Review
Copy Link

Should be:

console.debug('Replaced list view with', savedProjectView)
Should be: ```ts console.debug('Replaced list view with', savedProjectView) ```
konrad commented 2023-01-18 15:05:05 +00:00
Outdated
Review
Copy Link

I'd argue this is a project view here. It can be any of the four views (or at least that's what I meant when I originally added the log).

I'd argue this is a project view here. It can be any of the four views (or at least that's what I meant when I originally added the log).
dpschen commented 2023-01-18 15:26:36 +00:00
Outdated
Review
Copy Link

I thought that it was refering to the default view which is the 'list'. That's why it's replacing it. at all. If there is no saved view nothing will be replaced and the default stays list.

I thought that it was refering to the default view which is the 'list'. That's why it's replacing it. at all. If there is no saved view nothing will be replaced and the default stays list.
konrad commented 2023-01-18 15:51:45 +00:00
Outdated
Review
Copy Link

okay that makes sense.

okay that makes sense.
konrad commented 2023-01-18 15:52:18 +00:00
Outdated
Review
Copy Link

Changed!

Changed!