vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: rename lists to projects #2697

Closed
konrad wants to merge 53 commits from feature/rename-lists-to-projects into main
pull from: feature/rename-lists-to-projects
merge into: vikunja:main
Conversation 11 Commits 53 Files Changed 156 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8338cfbc8d - Show all commits

2
src/composables/useTaskList.ts
View File

@ -42,7 +42,7 @@ const SORT_BY_DEFAULT = {
}
/**
* This mixin provides a base set of methods and properties to get tasks on a project.
* This mixin provides a base set of methods and properties to get tasks.
konrad marked this conversation as resolved Outdated
dpschen commented 2023-01-18 14:39:45 +00:00
Outdated
Review
Copy Link

Maybe we can write here now:

This mixin provides a base set of methods and properties to get tasks.

Maybe we can write here now: `This mixin provides a base set of methods and properties to get tasks.`
konrad commented 2023-01-18 14:57:55 +00:00
Outdated
Review
Copy Link

Done

Done
*/
export function useTaskList(projectId, sortByDefault = SORT_BY_DEFAULT) {
konrad marked this conversation as resolved
dpschen commented 2023-01-18 14:42:31 +00:00
Review
Copy Link

I use list usually as a suffix to indicate that there are multiple items. E.g. if a have a component with a for loop I will add a foobar__list to the wrapper with the v-for and a foobar__item to the individual items inside. This is the logic used for naming this. Maybe collection would be a better wording now, since after the merge of this branch 'list' will mostly refer to the layout not the data format.

I use `list` usually as a suffix to indicate that there are multiple items. E.g. if a have a component with a for loop I will add a `foobar__list` to the wrapper with the `v-for` and a `foobar__item` to the individual items inside. This is the logic used for naming this. Maybe `collection` would be a better wording now, since after the merge of this branch 'list' will mostly refer to the layout not the data format.
konrad commented 2023-01-18 15:00:03 +00:00
Review
Copy Link

ohh so listId here is not the id of the list but some identifier about the current "list of things"? The way it gets used in getAllTasksParams` looked like a (now) project id.

ohh so `listId` here is not the id of the list but some identifier about the current "list of things"? The way it gets used in getAllTasksParams` looked like a (now) project id.
dpschen commented 2023-01-18 15:46:46 +00:00
Review
Copy Link

ohh so listId here is not the id of the list but some identifier about the current "list of things"? The way it gets used in getAllTasksParams` looked like a (now) project id.

Tbh I'm unsure about this. I have also adjusted this massively and don't rembember the original function as it is here very well.

Can we keep this for now as useTaskList? I could still change the name later (maybe just useProject?).

> ohh so listId here is not the id of the list but some identifier about the current "list of things"? The way it gets used in getAllTasksParams` looked like a (now) project id. Tbh I'm unsure about this. I have also adjusted this massively and don't rembember the original function as it is here very well. Can we keep this for now as useTaskList? I could still change the name later (maybe just `useProject`?).
konrad commented 2023-01-18 16:04:13 +00:00
Review
Copy Link

so leaving it as it is now? The name of the function did not change, only the parameter.

so leaving it as it is now? The name of the function did not change, only the parameter.
dpschen commented 2023-01-18 21:26:15 +00:00
Review
Copy Link

Yes, that's what I meant :)

Yes, that's what I meant :)
👍 1 🎉 1
const params = ref({...getDefaultParams()})