vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: rename lists to projects #2697

Closed
konrad wants to merge 53 commits from feature/rename-lists-to-projects into main
pull from: feature/rename-lists-to-projects
merge into: vikunja:main
Conversation 11 Commits 53 Files Changed 156 +3 -1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a058b39aba - Show all commits

4
src/stores/tasks.ts
View File

@ -342,9 +342,11 @@ export const useTaskStore = defineStore('task', () => {
{ project: string, projectId: IProject['id'] }) {
let foundProjectId = null
console.log('find', {projectName, projectId})
konrad marked this conversation as resolved Outdated
dpschen commented 2023-01-18 14:23:27 +00:00
Outdated
Review
Copy Link

Here is some leftover

Here is some leftover
konrad commented 2023-01-18 15:08:34 +00:00
Outdated
Review
Copy Link

whoops, removed.

whoops, removed.
// Uses the following ways to get the project id of the new task:
// 1. If specified in quick add magic, look in store if it exists and use it if it does
if (projectName !== null) {
if (typeof projectName !== 'undefined' && projectName !== null) {
konrad marked this conversation as resolved Outdated
dpschen commented 2023-01-18 14:24:42 +00:00
Outdated
Review
Copy Link

Is this a changed new condition or are we reverting here something that should only check for !== null?

Is this a changed new condition or are we reverting here something that should only check for `!== null`?
konrad commented 2023-01-18 21:14:45 +00:00
Outdated
Review
Copy Link

I discovered how it failed when projectName was undefined and it should behave the same as the if. It's a changed new condition.

I discovered how it failed when `projectName` was undefined and it should behave the same as the if. It's a changed new condition.
const project = projectStore.findProjectByExactname(projectName)
foundProjectId = project === null ? null : project.id
}