vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Docker refactoring #3018

Merged
konrad merged 6 commits from vlasov-y/frontend:main into main 2023-01-29 14:47:24 +00:00
Conversation 10 Commits 6 Files Changed 7 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fd1844c924 - Show all commits

4
Dockerfile
View File

@ -48,8 +48,8 @@ FROM nginx:stable-alpine AS runner
WORKDIR /usr/share/nginx/html
LABEL maintainer="maintainers@vikunja.io"
ENV VIKUNJA_HTTP_PORT 8080
ENV VIKUNJA_HTTP2_PORT 8081
ENV VIKUNJA_HTTP_PORT 80
ENV VIKUNJA_HTTP2_PORT 80
konrad commented 2023-01-27 11:36:19 +00:00
Outdated
Review
Copy Link

Do we even need to let users change these ports? Isn't it enough to choose a different "outer" port when running and publishing the container?

Do we even need to let users change these ports? Isn't it enough to choose a different "outer" port when running and publishing the container?
vlasov-y commented 2023-01-27 12:21:44 +00:00
Outdated
Review
Copy Link

Depends... Maybe someone will want to run the container in host network. If you want, I can just hardcode to 8080 and 8081.

Depends... Maybe someone will want to run the container in host network. If you want, I can just hardcode to 8080 and 8081.
👍 1
ENV VIKUNJA_LOG_FORMAT main
ENV VIKUNJA_API_URL http://localhost:3456/api/v1
ENV VIKUNJA_SENTRY_ENABLED false