vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: hide quick add magic help behind a tooltip #3353

Merged
konrad merged 13 commits from feature/hide-quick-add-magic-help into main 2023-06-05 15:02:43 +00:00
Conversation 1 Commits 13 Files Changed 6 +5 -4
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a4c8fccb11 - Show all commits

9
src/components/tasks/partials/quick-add-magic.vue
View File

@ -116,9 +116,10 @@ const prefixes = computed(() => PREFIXES[mode.value])
.show-helper-text {
right: 0;
konrad marked this conversation as resolved Outdated
dpschen commented 2023-04-12 18:15:04 +00:00
Outdated
Review
Copy Link

Positioning should happen from outside. Remove right: 0 from here

Positioning should happen from outside. Remove `right: 0` from here
konrad commented 2023-04-14 14:03:20 +00:00
Outdated
Review
Copy Link

Done

Done
konrad commented 2023-04-14 14:04:06 +00:00
Outdated
Review
Copy Link

I had to use an unscoped style for this because I could not add a new class to the quick-add-magic component due to it being multi-node. Not sure if that's the best solution.

I had to use an unscoped style for this because I could not add a new class to the `quick-add-magic` component due to it being multi-node. Not sure if that's the best solution.
pointer-events: auto !important;
konrad marked this conversation as resolved Outdated
dpschen commented 2023-04-12 18:14:13 +00:00
Outdated
Review
Copy Link

Why pointer-events: auto?

Why `pointer-events: auto`?
konrad commented 2023-04-14 13:58:36 +00:00
Outdated
Review
Copy Link

Because in BaseButton we set that to none which makes the button unclickable (and unhoverable).

Because in `BaseButton` we set that to `none` which makes the button unclickable (and unhoverable).
dpschen commented 2023-04-14 17:07:58 +00:00
Outdated
Review
Copy Link

That can't be it, because there it's set to auto as well: https://kolaente.dev/vikunja/frontend/src/branch/main/src/components/base/BaseButton.vue#L115

That can't be it, because there it's set to `auto` as well: https://kolaente.dev/vikunja/frontend/src/branch/main/src/components/base/BaseButton.vue#L115
👍 1
dpschen commented 2023-04-14 17:12:10 +00:00
Outdated
Review
Copy Link

Seems to be the .control.has-icons-left .icon class of bulma. Can you add a comment?

It also seems that the textarea could profit from has-icon-right so that there is enough padding for the button.

Seems to be the `.control.has-icons-left .icon` class of bulma. Can you add a comment? It also seems that the textarea could profit from `has-icon-right` so that there is enough padding for the button.
konrad commented 2023-04-14 19:20:16 +00:00
Outdated
Review
Copy Link

Added a comment and more padding.

Added a comment and more padding.
&.is-highlighted {
color: inherit !important;
}
}
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-04-12 18:09:43 +00:00
Outdated
Review
Copy Link

Is nesting even necessary if we already need to use !important for inheriting the color?

Is nesting even necessary if we already need to use `!important` for inheriting the color?
✅ 1
konrad commented 2023-04-14 13:56:01 +00:00
Outdated
Review
Copy Link

It isn't, I added the nesting out of habit. Removed it now.

It isn't, I added the nesting out of habit. Removed it now.
.is-highlighted {
color: inherit !important;
}
</style>