vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: move user settings to multiple components #889

Merged
konrad merged 27 commits from feature/user-settings into main 2021-10-26 20:58:03 +00:00
Conversation 1 Commits 27 Files Changed 16 +9 -5
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8d1d80dec8 - Show all commits

3
src/store/modules/config.js
View File

@ -35,6 +35,9 @@ export default {
},
},
}),
getters: {
migratorsEnabled: state => state.availableMigrators !== null && state.availableMigrators.length > 0,
konrad marked this conversation as resolved Outdated
dpschen commented 2021-10-25 19:50:00 +00:00
Outdated
Review
Copy Link

use state.availableMigrators?.length > 0

use `state.availableMigrators?.length > 0`
},
mutations: {
[CONFIG](state, config) {
state.version = config.version

11
src/views/user/Settings.vue
View File

@ -63,11 +63,12 @@ export default {
mounted() {
this.setTitle(this.$t('user.settings.title'))
},
computed: mapState({
totpEnabled: state => state.config.totpEnabled,
migratorsEnabled: state => state.config.availableMigrators !== null && state.config.availableMigrators.length > 0,
caldavEnabled: state => state.config.caldavEnabled,
}),
computed: {
konrad marked this conversation as resolved Outdated
dpschen commented 2021-10-23 10:58:36 +00:00
Outdated
Review
Copy Link

How about making migratorsEnabled a getter in the store?

How about making `migratorsEnabled` a getter in the store?
dpschen commented 2021-10-23 10:59:46 +00:00
Outdated
Review
Copy Link

The rest can be simplified with:

computed: {
	...mapState('config', ['totpEnabled', 'caldavEnabled'],
	[...]
}
The rest can be simplified with: ```js computed: { ...mapState('config', ['totpEnabled', 'caldavEnabled'], [...] } ```
konrad commented 2021-10-25 19:37:08 +00:00
Outdated
Review
Copy Link

Done (both of it).

Done (both of it).
🎉 1
...mapState('config', ['totpEnabled', 'caldavEnabled']),
migratorsEnabled() {
return this.$store.getters['config/migratorsEnabled']
},
},
}
</script>