vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: defer everything until the api config is loaded #926

Merged
konrad merged 27 commits from feature/ready-state into main 2021-11-13 19:49:03 +00:00
Conversation 3 Commits 27 Files Changed 10 +3 -4
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 628d102907 - Show all commits

7
src/components/misc/ready.vue
View File

@ -45,7 +45,6 @@ import logoUrl from '@/assets/logo.svg'
import ApiConfig from '@/components/misc/api-config'
import NoAuthWrapper from '@/components/misc/no-auth-wrapper'
import {mapState} from 'vuex'
import {ONLINE} from '@/store/mutation-types'
import {ERROR_NO_API_URL} from '@/helpers/checkAndSetApiUrl'
export default {
@ -71,9 +70,9 @@ export default {
showLoading() {
return !this.ready && this.error === ''
},
...mapState({
online: ONLINE,
}),
...mapState([
'online',
]),
konrad marked this conversation as resolved Outdated
dpschen commented 2021-11-10 19:28:47 +00:00
Outdated
Review
Copy Link

ONLINE is no mutation type. It's a state.

`ONLINE` is no mutation type. It's a state.
konrad commented 2021-11-10 19:53:07 +00:00
Outdated
Review
Copy Link

Right, fixed.

Right, fixed.
},
methods: {
load() {