vikunja
/
helm-chart
2
2
Fork 5
Code Issues 6 Pull Requests Packages Projects Releases 1 Wiki Activity

Simplify defaults and link more external documentation #12

Merged
konrad merged 2 commits from xeruf/helm-chart:defaults into main 2023-09-29 17:17:07 +00:00
Conversation 1 Commits 2 Files Changed 2 +40 -51
xeruf commented 2023-09-18 09:08:21 +00:00
Contributor
Copy Link

No version bump needed since there are no relevant changes in options, merely making everything a little easier to handle.

No version bump needed since there are no relevant changes in options, merely making everything a little easier to handle.
xeruf added 1 commit 2023-09-18 09:08:22 +00:00
continuous-integration/drone/pr Build is passing Details
4b18eee272 Simplify defaults and link more external documentation
xeruf commented 2023-09-26 19:12:24 +00:00
Author
Contributor
Copy Link

@konrad :)

@konrad :)
konrad reviewed 2023-09-27 15:44:15 +00:00
README.md
@ -21,2 +14,2 @@
Once you have registered, you can disable registration back if you do not need it.
Define ingress settings according to your controller (for both API and Frontend) to access the application.
You can set all Vikunja API options as yaml under `api.config`: https://vikunja.io/docs/config-options
konrad commented 2023-09-27 15:42:29 +00:00
Owner
Copy Link

Can you leave the example?

Can you leave the example?
xeruf commented 2023-09-28 10:59:45 +00:00
Author
Contributor
Copy Link

I don't really find the example helpful because there is no context.
I would rather point to the values.yaml

I don't really find the example helpful because there is no context. I would rather point to the values.yaml
konrad commented 2023-09-29 17:16:17 +00:00
Owner
Copy Link

Makes sense.

Makes sense.
konrad marked this conversation as resolved
README.md Outdated
@ -131,6 +136,8 @@ This is helpful when migrating from a different k8s chart and want to re-use the
## Publishing
These steps are automatically performed on a git tag.
konrad commented 2023-09-27 15:43:56 +00:00
Owner
Copy Link

Suggestion:

-These steps are automatically performed on a git tag. 
+These steps are automatically performed when a version is tagged and pushed in the repo.
Suggestion: ```diff -These steps are automatically performed on a git tag. +These steps are automatically performed when a version is tagged and pushed in the repo. ```
xeruf marked this conversation as resolved
xeruf added 1 commit 2023-09-28 11:10:21 +00:00
continuous-integration/drone/pr Build is passing Details
9ae282a684 Link specific lines in values as examples
konrad merged commit 173698726d into main 2023-09-29 17:17:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/helm-chart#12
No description provided.
Delete Branch "xeruf/helm-chart:defaults"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?