Add sane default values for Ingress objects. #21

perfectra1n · 2023-12-12T22:35:22Z

perfectra1n commented

2023-12-12 22:35:22 +00:00

In the spirit of #19, I wanted to provide better sane defaults for the Ingress values:

frontend:
  ingress:
    main:
      enabled: true
      annotations:
        # proxy-body-size is set to 0 to remove the body limit on file uploads
        nginx.ingress.kubernetes.io/proxy-body-size: "0"
      hosts:
        # This is just an example. You should change this to your own domain.
        - host: vikunja.local
          paths:
            - path: /
              pathType: Prefix
      tls: []
api:
  ingress:
    api:
      enabled: true
      annotations:
        # proxy-body-size is set to 0 to remove the body limit on file uploads
        nginx.ingress.kubernetes.io/proxy-body-size: "0"
      hosts:
        - host: vikunja.local
          paths:
            - path: /api/v1
              pathType: Prefix
      tls: []

In the spirit of #19, I wanted to provide better sane defaults for the Ingress values: ```yaml frontend: ingress: main: enabled: true annotations: # proxy-body-size is set to 0 to remove the body limit on file uploads nginx.ingress.kubernetes.io/proxy-body-size: "0" hosts: # This is just an example. You should change this to your own domain. - host: vikunja.local paths: - path: / pathType: Prefix tls: [] api: ingress: api: enabled: true annotations: # proxy-body-size is set to 0 to remove the body limit on file uploads nginx.ingress.kubernetes.io/proxy-body-size: "0" hosts: - host: vikunja.local paths: - path: /api/v1 pathType: Prefix tls: [] ```

perfectra1n added 5 commits 2023-12-12 22:35:23 +00:00

continuous-integration/drone/pr Build is passing Details

9bebe367e7

Create artifacthub-repo.yml file

continuous-integration/drone/pr Build is passing Details

69bd339f5f artifacthub-repo.yml aktualisiert

f6555063dd

Merge remote-tracking branch 'upstream/main'

35379c20e7

add sane defaults for Ingress

continuous-integration/drone/pr Build is passing Details

f1a10ce395

fix frontend port

perfectra1n commented

2023-12-12 22:37:20 +00:00

I guess I should've squashed first...

perfectra1n added 1 commit 2023-12-12 22:43:14 +00:00

continuous-integration/drone/pr Build is passing Details

aaceb9f2f7

change this ingress name to be `main` as well

konrad commented

2023-12-12 22:43:53 +00:00

Should we merge this before or after #19?

perfectra1n commented

2023-12-12 22:47:10 +00:00

I was just about to flip this as WIP @konrad - I got all spun around. The chart as is already creates the correct Ingress objects by default. I'll go ahead and close this out, this is what I get for trying to write code while in meetings...

I was just about to flip this as WIP @konrad - I got all spun around. The chart as is already creates the correct `Ingress` objects by default. I'll go ahead and close this out, this is what I get for trying to write code while in meetings...

perfectra1n closed this pull request

2023-12-12 22:47:10 +00:00

perfectra1n commented

2023-12-12 22:49:42 +00:00

I realized I was doing something silly when I saw so few lines of code changed LOL

continuous-integration/drone/pr Build is passing

Required

Details