vikunja
/
helm-chart
2
2
Fork 5
Code Issues 6 Pull Requests Packages Projects Releases 1 Wiki Activity

Fix 'raw' template #7

Merged
konrad merged 3 commits from vgrassia/helm-chart:main into main 2023-09-15 09:41:45 +00:00
Conversation 2 Commits 3 Files Changed 2 +2 -2
vgrassia commented 2023-05-02 14:20:12 +00:00
Contributor
Copy Link

The raw.yaml template was not generating manifests for the custom resources defined in the values.yaml file. This PR fixes the variable to loop over in the template.

Closes vikunja/helm-chart#5

The `raw.yaml` template was not generating manifests for the custom resources defined in the `values.yaml` file. This PR fixes the variable to loop over in the template. Closes vikunja/helm-chart#5
vgrassia added 1 commit 2023-05-02 14:20:13 +00:00
continuous-integration/drone/pr Build is passing Details
cd918af188 Fix 'raw' template
konrad requested review from vlasov-y 2023-05-02 14:25:21 +00:00
vgrassia force-pushed main from cd918af188 to 966fd845f2 2023-05-07 23:44:56 +00:00 Compare
konrad commented 2023-05-08 13:40:32 +00:00
Owner
Copy Link

@vlasov-y Can you take a look here?

@vlasov-y Can you take a look here?
vlasov-y approved these changes 2023-05-10 07:45:19 +00:00
vlasov-y commented 2023-05-10 07:46:48 +00:00
Member
Copy Link

@vgrassia Thanks for fixing! That was "Find&Replace" issue, like copy-paste :)

FIY @konrad I have approved, but we have to increment patch version in Chart.yaml before merge. @vgrassia Can you update your branch or we will do it our side?

@vgrassia Thanks for fixing! That was "Find&Replace" issue, like copy-paste :) FIY @konrad I have approved, but we have to increment patch version in Chart.yaml before merge. @vgrassia Can you update your branch or we will do it our side?
👍 1
vgrassia added 1 commit 2023-05-10 15:20:59 +00:00
continuous-integration/drone/pr Build is failing Details
43379c3c3a Increment Chart patch version
konrad added 1 commit 2023-09-15 09:41:14 +00:00
continuous-integration/drone/pr Build is passing Details
b59cd715e3
merge with main
konrad merged commit 419c58c6f1 into main 2023-09-15 09:41:45 +00:00
konrad referenced this issue from a commit 2023-09-15 09:41:45 +00:00
fix: 'raw' template (#7)
Sign in to join this conversation.
Reviewers
No reviewers
vlasov-y
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/helm-chart#7
No description provided.
Delete Branch "vgrassia/helm-chart:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?